From: Maxim Levitsky <mlevitsk@redhat.com>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] Add vhost-pci-blk driver
Date: Mon, 05 Nov 2018 15:21:21 +0200 [thread overview]
Message-ID: <4222cd0b956ac767f74b56a32772d190d1b84b51.camel@redhat.com> (raw)
In-Reply-To: <20181102191538.7532-1-v.mayatskih@gmail.com>
On Fri, 2018-11-02 at 19:15 +0000, Vitaly Mayatskikh wrote:
> This driver uses the kernel-mode acceleration for virtio-blk and
> allows to get a near bare metal disk performance inside a VM.
>
> Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
> ---
> configure | 10 +++++++
> default-configs/virtio.mak | 1 +
> hw/block/Makefile.objs | 1 +
> hw/virtio/virtio-pci.c | 60 ++++++++++++++++++++++++++++++++++++++
> hw/virtio/virtio-pci.h | 19 ++++++++++++
> 5 files changed, 91 insertions(+)
>
I think that you haven't sent all the files because at least some of the files
are missing.
For example the build fails with missing 'hw/virtio/vhost-blk.h'
Also I don't see here any mention on how the qemu passes to the in-kernel
driver, the file which the in-kernel driver is supposed to read/write.
I don't think that generic vhost backend have this functionality because till
now it was limited to iscsi, and thus qemu just passed to the kernel, the wwpn
of the device.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2018-11-05 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:15 [Qemu-devel] [PATCH 1/1] Add vhost-pci-blk driver Vitaly Mayatskikh
2018-11-05 13:21 ` Maxim Levitsky [this message]
2018-11-05 13:55 ` Vitaly Mayatskih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4222cd0b956ac767f74b56a32772d190d1b84b51.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=v.mayatskih@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).