Re: [Qemu-devel] [Patch] Release mouse at window edges

[Oliver Gerlich <olig9@gmx.de>]

Brad Campbell wrote:
> Fabrice Bellard wrote:
> 
>> The idea is interesting. Does it cause regressions in the normal mode 
>> ? If so, an option to enable it may be good. I think it is a problem 
>> that your patch is dependent on the cursor size.
>>
> 
> This is a good point. I have had to revert it for WinXP as every time 
> the cursor changes shape (and it does all the time as you move over 
> stuff in Office2003) it releases the grab.
> 
> In addition I have had all manner of painting and rendering issues with 
> the IDG display driver and have had to revert to the built in driver to 
> get some software to paint properly.
> 
> Nice idea, might need a little work still.
> 
> Brad

An extra switch would be good, indeed. Currently, grabbing/ungrabbing is 
disabled if no hw cursor is used, but it's not reliable enough (for 
example, Linux initializes hw cursor at framebuffer initialization, 
although no cursor is visible).

The problem with cursor size appears differently on different systems. 
On Win98, hw_cursor_x goes from 1 to 1023 (in 1024x768), while on Win2k, 
it goes from 0 to 1013... The patch circumvents this problem with an 
ugly hack, but I have no idea how to get around this cleanly.

Brad: your problems with Office might be related to another bug I 
discovered (Internet Explorer 5 "disables" hw cursor by moving the 
cursor to 2047/2047 which ungrabs the cursor as soon as it enters an IE 
window). I'll post an improved patch tonight, with this and other bugs 
fixed.

BTW. is there a "make realclean" (or similar) which also deletes 
qemu-doc.html, manpages, kqemu temp files etc, so that I can easily diff 
my patched snapshot to an unpatched one?

Oliver Gerlich