From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmc8H-00035S-I9 for qemu-devel@nongnu.org; Thu, 24 Jan 2019 05:21:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmbvi-0000d0-Db for qemu-devel@nongnu.org; Thu, 24 Jan 2019 05:08:16 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmbvi-0000Yz-30 for qemu-devel@nongnu.org; Thu, 24 Jan 2019 05:08:14 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0O9wlwQ138679 for ; Thu, 24 Jan 2019 05:08:12 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2q78hegbtn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 Jan 2019 05:08:11 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Jan 2019 10:08:09 -0000 Reply-To: pmorel@linux.ibm.com References: <20190121110354.2247-1-cohuck@redhat.com> <20190121110354.2247-3-cohuck@redhat.com> <20190122193346.4e23e018@oc2783563651> <20190123112112.7822b237.cohuck@redhat.com> From: Pierre Morel Date: Thu, 24 Jan 2019 11:08:02 +0100 MIME-Version: 1.0 In-Reply-To: <20190123112112.7822b237.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Message-Id: <42264dd9-86d7-8994-8c25-bc688067725d@linux.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Halil Pasic Cc: Eric Farman , Farhan Ali , linux-s390@vger.kernel.org, kvm@vger.kernel.org, Alex Williamson , qemu-devel@nongnu.org, qemu-s390x@nongnu.org On 23/01/2019 11:21, Cornelia Huck wrote: > On Tue, 22 Jan 2019 19:33:46 +0100 > Halil Pasic wrote: >=20 >> On Mon, 21 Jan 2019 12:03:51 +0100 >> Cornelia Huck wrote: >> >>> --- a/drivers/s390/cio/vfio_ccw_private.h >>> +++ b/drivers/s390/cio/vfio_ccw_private.h >>> @@ -28,6 +28,7 @@ >>> * @mdev: pointer to the mediated device >>> * @nb: notifier for vfio events >>> * @io_region: MMIO region to input/output I/O arguments/results >>> + * @io_mutex: protect against concurrent update of I/O structures >> >> We could be a bit more specific about what does this mutex guard. >> Is it only io_region, or cp, irb and the new regions a well? ->state d= oes >> not seem to be covered, but should need some sort of synchronisation >> too, or? >=20 > I'm not sure. IIRC Pierre had some ideas about locking in the fsm? >=20 Yes I postponed this work to not collide with your patch series. Do you think I should provide a new version of the FSM reworking series=20 based on the last comment I got? I would take into account that the asynchronous commands will come with=20 your patch series and only provide the framework changes. Regards, Pierre --=20 Pierre Morel Linux/KVM/QEMU in B=C3=B6blingen - Germany