From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: peer.adelt@c-lab.de, qemu-devel@nongnu.org
Cc: rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-tricore: Added new JNE instruction variant
Date: Tue, 7 Jun 2016 18:51:24 +0200 [thread overview]
Message-ID: <423be5b8-646e-78d4-b6c2-bc05ed3ad0b5@mail.uni-paderborn.de> (raw)
In-Reply-To: <1465314555-11501-5-git-send-email-peer.adelt@c-lab.de>
On 06/07/2016 05:49 PM, peer.adelt@c-lab.de wrote:
> From: Peer Adelt <peer.adelt@c-lab.de>
>
> If D[15] is != sign_ext(const4) then PC will be set to (PC +
> zero_ext(disp4 + 16)).
>
> Signed-off-by: Peer Adelt <peer.adelt@c-lab.de>
> ---
> target-tricore/translate.c | 16 ++++++++++++++++
> target-tricore/tricore-opcodes.h | 2 ++
> 2 files changed, 18 insertions(+)
>
Minor nitpick -- the commit message should reflect that you added the
JEQ variant as well. But I could do that when applying it to my
tricore-next tree.
Otherwise:
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
prev parent reply other threads:[~2016-06-07 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 15:49 [Qemu-devel] [PATCH v3 0/4] Added 5 instructions to the tricore target peer.adelt
2016-06-07 15:49 ` [Qemu-devel] [PATCH v3 1/4] target-tricore: Added FTOUZ instruction peer.adelt
2016-06-07 15:49 ` [Qemu-devel] [PATCH v3 2/4] target-tricore: Added MADD.F and MSUB.F instructions peer.adelt
2016-06-09 11:00 ` Bastian Koppelmann
2016-06-07 15:49 ` [Qemu-devel] [PATCH v3 3/4] target-tricore: Added new MOV instruction variant peer.adelt
2016-06-07 16:48 ` Bastian Koppelmann
2016-06-07 15:49 ` [Qemu-devel] [PATCH v3 4/4] target-tricore: Added new JNE " peer.adelt
2016-06-07 16:51 ` Bastian Koppelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423be5b8-646e-78d4-b6c2-bc05ed3ad0b5@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@c-lab.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).