From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Kamil Rytarowski" <n54@gmx.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, claudio.fontana@huawei.com
Subject: Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build
Date: Mon, 15 May 2017 08:57:16 -0500 [thread overview]
Message-ID: <4245846f-2977-6f1b-a5a0-80d92bfe42d4@redhat.com> (raw)
In-Reply-To: <91e1cbd3-88e6-2b7a-c4e4-824c54f34c52@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote:
> Hi Kamil,
>
> I think it is safer to add it in disas/libvixl/Makefile.objs where
> QEMU_CFLAGS are tuned for libvixl.
> This way you don't need to modify upstream libvixl.
>
Ah, right. disas/libvixl is one of the directories exempt from our
normal rules of including osdep.h first (otherwise I would have said
that including stdint.h first should be the job of osdep.h).
But indeed, that's because we are trying to leave libvixl as untouched
as possible, so if there IS a solution that can be done through
makefiles rather than direct file editing, it is worth considering.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-15 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 1:54 [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build Kamil Rytarowski
2017-05-13 22:04 ` Philippe Mathieu-Daudé
2017-05-13 22:15 ` Kamil Rytarowski
2017-05-15 13:57 ` Eric Blake [this message]
2017-05-15 13:57 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4245846f-2977-6f1b-a5a0-80d92bfe42d4@redhat.com \
--to=eblake@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=f4bug@amsat.org \
--cc=n54@gmx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).