From: Fabrice Bellard <fabrice@bellard.org>
To: paul@codesourcery.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] CPU_DoubleU and soft-float
Date: Thu, 07 Apr 2005 21:47:51 +0200 [thread overview]
Message-ID: <42558E67.2060007@bellard.org> (raw)
In-Reply-To: <200503262053.32734.paul@codesourcery.com>
OK for the patch.
It would be better to force the use of soft float on ARM if the VFP is
not present. Supporting weird ordering for doubles is a source of
problems and soft float may be faster than the kernel based ARM fpu
emulator anyway.
Fabrice.
Paul Brook wrote:
> The definition of CPU_DoubleU is incorrect on arm hosts when using
> soft-float. In this case "float64" will have host integer word ordering, not
> host hardware float ordering.
>
> Paul
>
> Index: cpu-all.h
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/cpu-all.h,v
> retrieving revision 1.42
> diff -u -p -r1.42 cpu-all.h
> --- cpu-all.h 13 Mar 2005 18:50:23 -0000 1.42
> +++ cpu-all.h 26 Mar 2005 20:48:25 -0000
> @@ -120,7 +120,8 @@ static inline void tswap64s(uint64_t *s)
> endian ! */
> typedef union {
> float64 d;
> -#if defined(WORDS_BIGENDIAN) || (defined(__arm__) && !defined(__VFP_FP__))
> +#if defined(WORDS_BIGENDIAN) \
> + || (defined(__arm__) && !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT))
> struct {
> uint32_t upper;
> uint32_t lower;
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
next prev parent reply other threads:[~2005-04-07 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 20:53 [Qemu-devel] [patch] CPU_DoubleU and soft-float Paul Brook
2005-04-07 19:47 ` Fabrice Bellard [this message]
2005-04-08 0:05 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42558E67.2060007@bellard.org \
--to=fabrice@bellard.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).