From: Fabrice Bellard <fabrice@bellard.org>
To: mark.jonckheere@easynet.be
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ne2000 and Netware 3.11
Date: Thu, 07 Apr 2005 22:15:43 +0200 [thread overview]
Message-ID: <425594EF.5090801@bellard.org> (raw)
In-Reply-To: <42415A89.9000903@easynet.be>
Mark Jonckheere wrote:
> ++++++++++++++++++++++++
> diff -wurb qemu/hw/ne2000.c qemu-patched/hw/ne2000.c
> --- qemu/hw/ne2000.c Sun Oct 3 15:56:00 2004
> +++ qemu-patched/hw/ne2000.c Tue Mar 22 20:13:07 2005
> @@ -289,7 +290,8 @@
> ne2000_update_irq(s);
> break;
> case EN0_TPSR:
> - s->tpsr = val;
> + /* XXX: only 32K memory available, ignore bit 8 */
> + s->tpsr = val & 0x7f;
> break;
> case EN0_TCNTLO:
> s->tcnt = (s->tcnt & 0xff00) | val;
This patch is not correct: it limits the memory to 16K, not 32K because
the memory starts at a 16K offset. A possible solution could be to wrap
to 16K only if (tpsr << 8) >= 48K. Moreover, it should be done in the
packet transmit code.
> Note:this patch also includes the patch I proposed on 24-12-2004
> with title: "[PATCH] ne2000: Reset TXP bit after sending packet."
> since it is also needed to make Netware recognise the ne2000 card.
OK for this one.
Fabrice.
next prev parent reply other threads:[~2005-04-07 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 12:01 [Qemu-devel] [PATCH] ne2000 and Netware 3.11 Mark Jonckheere
2005-04-07 20:15 ` Fabrice Bellard [this message]
2005-04-08 13:56 ` [Qemu-devel] Re: [PATCH] ne2000 and Netware 3.11 (Revised patch) Mark Jonckheere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425594EF.5090801@bellard.org \
--to=fabrice@bellard.org \
--cc=mark.jonckheere@easynet.be \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).