From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DNFVX-0004kX-EQ for qemu-devel@nongnu.org; Sun, 17 Apr 2005 15:32:39 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNFVT-0004i6-P3 for qemu-devel@nongnu.org; Sun, 17 Apr 2005 15:32:36 -0400 Received: from [129.104.30.34] (helo=mx1.polytechnique.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DNFUB-00039s-Dj for qemu-devel@nongnu.org; Sun, 17 Apr 2005 15:31:15 -0400 Received: from [84.99.204.192] (192.204.99-84.rev.gaoland.net [84.99.204.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id 335BC3316F for ; Sun, 17 Apr 2005 21:29:50 +0200 (CEST) Message-ID: <4262B994.6010807@bellard.org> Date: Sun, 17 Apr 2005 21:31:32 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] compiler error in CONFIG_S3VGA References: <20050417185200.GF15688@aon.at> In-Reply-To: <20050417185200.GF15688@aon.at> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org In fact the real fix is to delete the S3VGA stuff - it has never worked and I have no plan to support it. Moveover, a correct implementation would be made in another driver as the cirrus_vga driver. Fabrice. Bernhard Fischer wrote: > Hi, > > qemu/hw/vga.c: typo: s/uinr32_t/uint32_t/ > > Thank you, > > > ------------------------------------------------------------------------ > > diff -X excl -rduNp qemu.oorig/hw/vga.c qemu/hw/vga.c > --- qemu.oorig/hw/vga.c 2005-02-10 23:00:27.000000000 +0100 > +++ qemu/hw/vga.c 2005-04-17 02:47:10.000000000 +0200 > @@ -956,7 +956,7 @@ static void vga_get_offsets(VGAState *s, > line_offset = s->cr[0x13]; > #ifdef CONFIG_S3VGA > { > - uinr32_t v; > + uint32_t v; > v = (s->cr[0x51] >> 4) & 3; /* S3 extension */ > if (v == 0) > v = (s->cr[0x43] >> 2) & 1; /* S3 extension */ > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel