[Qemu-devel] compiler error in CONFIG_S3VGA

[Qemu-devel] compiler error in CONFIG_S3VGA

[Bernhard Fischer]

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Hi,

qemu/hw/vga.c: typo: s/uinr32_t/uint32_t/

Thank you,

[-- Attachment #2: qemu.typedef_typo_in_DEBUG.diff --]
[-- Type: text/plain, Size: 497 bytes --]

diff -X excl -rduNp qemu.oorig/hw/vga.c qemu/hw/vga.c
--- qemu.oorig/hw/vga.c	2005-02-10 23:00:27.000000000 +0100
+++ qemu/hw/vga.c	2005-04-17 02:47:10.000000000 +0200
@@ -956,7 +956,7 @@ static void vga_get_offsets(VGAState *s,
         line_offset = s->cr[0x13];
 #ifdef CONFIG_S3VGA
         {
-            uinr32_t v;
+            uint32_t v;
             v = (s->cr[0x51] >> 4) & 3; /* S3 extension */
             if (v == 0)
                 v = (s->cr[0x43] >> 2) & 1; /* S3 extension */

Re: [Qemu-devel] compiler error in CONFIG_S3VGA

[Fabrice Bellard]

In fact the real fix is to delete the S3VGA stuff - it has never worked 
and I have no plan to support it. Moveover, a correct implementation 
would be made in another driver as the cirrus_vga driver.

Fabrice.

Bernhard Fischer wrote:
> Hi,
> 
> qemu/hw/vga.c: typo: s/uinr32_t/uint32_t/
> 
> Thank you,
> 
> 
> ------------------------------------------------------------------------
> 
> diff -X excl -rduNp qemu.oorig/hw/vga.c qemu/hw/vga.c
> --- qemu.oorig/hw/vga.c	2005-02-10 23:00:27.000000000 +0100
> +++ qemu/hw/vga.c	2005-04-17 02:47:10.000000000 +0200
> @@ -956,7 +956,7 @@ static void vga_get_offsets(VGAState *s,
>          line_offset = s->cr[0x13];
>  #ifdef CONFIG_S3VGA
>          {
> -            uinr32_t v;
> +            uint32_t v;
>              v = (s->cr[0x51] >> 4) & 3; /* S3 extension */
>              if (v == 0)
>                  v = (s->cr[0x43] >> 2) & 1; /* S3 extension */
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] compiler error in CONFIG_S3VGA

[Bernhard Fischer]

On Sun, Apr 17, 2005 at 09:31:32PM +0200, Fabrice Bellard wrote:
>In fact the real fix is to delete the S3VGA stuff - it has never worked 
>and I have no plan to support it. Moveover, a correct implementation 
>would be made in another driver as the cirrus_vga driver.

Also remove the DEBUG_TB_CHECK path, which gives me errors at link-time
(page_get_flags) if CONFIG_USER_ONLY is not defined?