From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bX9iH-0003Yp-Os
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:17:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bX9iE-0008UT-IJ
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:17:09 -0400
Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:38117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bX9iE-0008UM-B3
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:17:06 -0400
Received: by mail-wm0-x235.google.com with SMTP id o80so45865431wme.1
	for <qemu-devel@nongnu.org>; Tue, 09 Aug 2016 09:17:06 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1470756748-18933-1-git-send-email-berrange@redhat.com>
	<1470756748-18933-9-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <426f9bff-4bff-3b80-e236-1cde6c3ab423@redhat.com>
Date: Tue, 9 Aug 2016 18:17:04 +0200
MIME-Version: 1.0
In-Reply-To: <1470756748-18933-9-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 08/60] trace: provide mechanism
 for registering trace events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>



On 09/08/2016 17:31, Daniel P. Berrange wrote:
> +    out('void trace_register_events(void)',
> +        '{',
> +        '    trace_event_register_group(trace_events, TRACE_EVENT_COUNT);',
> +        '}',
> +        'trace_init(trace_register_events)')

Should this function be static?

Paolo