From: "Rémi Denis-Courmont" <remi.denis.courmont@huawei.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 16/18] target/arm: add ARMv8.4-SEL2 extension
Date: Tue, 12 Jan 2021 09:33:58 +0200 [thread overview]
Message-ID: <4284205.LvFx2qVVIh@basile.remlab.net> (raw)
In-Reply-To: <4e32ca89-51aa-85d1-0a8f-e9aa7e037be4@linaro.org>
Le tiistaina 12. tammikuuta 2021, 2.13.29 EET Richard Henderson a écrit :
> On 12/18/20 12:37 AM, remi.denis.courmont@huawei.com wrote:
> > @@ -3297,7 +3301,7 @@ typedef ARMCPU ArchCPU;
> >
> > * We put flags which are shared between 32 and 64 bit mode at the top
> > * of the word, and flags which apply to only one mode at the bottom.
> > *
> >
> > - * 31 20 18 14 9 0
> > + * 31 20 19 14 9 0
> >
> > * +--------------+-----+-----+----------+--------------+
> > * | | | TBFLAG_A32 | |
> > * | | +-----+----------+ TBFLAG_AM32 |
> >
> > @@ -3346,6 +3350,7 @@ FIELD(TBFLAG_A32, HSTR_ACTIVE, 16, 1)
> >
> > * the same thing as the current security state of the processor!
> > */
> >
> > FIELD(TBFLAG_A32, NS, 17, 1)
> >
> > +FIELD(TBFLAG_A32, EEL2, 18, 1)
>
> Note that via other in-flight patch sets we have run out of bits here. I've
> rearranged them in
>
> https://patchew.org/QEMU/20210111190113.303726-1-richard.henderson@linaro.or
> g/
>
> This should be nothing but a minor confict to fix up.
I think we should get rid of that flag that's hardly if at all ever going to be
used. It should be possible to bypass gen_exception*() straight to
gen_helper_exception_with_syndrome(), so that the target EL can be computed at
run-time.
--
Rémi Denis-Courmont
next prev parent reply other threads:[~2021-01-12 7:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:37 [PATCHv4 00/18] ARMv8.4-A Secure EL2 Rémi Denis-Courmont
2020-12-18 10:37 ` [PATCH 01/18] target/arm: remove redundant tests remi.denis.courmont
2020-12-18 10:37 ` [PATCH 02/18] target/arm: add arm_is_el2_enabled() helper remi.denis.courmont
2020-12-18 10:37 ` [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable remi.denis.courmont
2020-12-21 20:54 ` Richard Henderson
2021-01-04 12:08 ` Rémi Denis-Courmont
2020-12-18 10:37 ` [PATCH 04/18] target/arm: use arm_hcr_el2_eff() " remi.denis.courmont
2020-12-18 10:37 ` [PATCH 05/18] target/arm: factor MDCR_EL2 common handling remi.denis.courmont
2020-12-18 10:37 ` [PATCH 06/18] target/arm: declare new AA64PFR0 bit-fields remi.denis.courmont
2020-12-18 10:37 ` [PATCH 07/18] target/arm: add 64-bit S-EL2 to EL exception table remi.denis.courmont
2021-01-12 0:04 ` Richard Henderson
2021-01-12 9:04 ` Rémi Denis-Courmont
2021-01-12 9:55 ` Peter Maydell
2020-12-18 10:37 ` [PATCH 08/18] target/arm: add MMU stage 1 for Secure EL2 remi.denis.courmont
2020-12-18 10:37 ` [PATCH 09/18] target/arm: add ARMv8.4-SEL2 system registers remi.denis.courmont
2021-01-12 0:05 ` Richard Henderson
2020-12-18 10:37 ` [PATCH 10/18] target/arm: handle VMID change in secure state remi.denis.courmont
2020-12-18 10:37 ` [PATCH 11/18] target/arm: do S1_ptw_translate() before address space lookup remi.denis.courmont
2020-12-18 10:37 ` [PATCH 12/18] target/arm: translate NS bit in page-walks remi.denis.courmont
2021-01-12 0:06 ` Richard Henderson
2020-12-18 10:37 ` [PATCH 13/18] target/arm: generalize 2-stage page-walk condition remi.denis.courmont
2021-01-12 0:07 ` Richard Henderson
2020-12-18 10:37 ` [PATCH 14/18] target/arm: secure stage 2 translation regime remi.denis.courmont
2021-01-12 0:19 ` Richard Henderson
2021-01-12 7:27 ` Rémi Denis-Courmont
2021-01-12 0:20 ` Richard Henderson
2021-01-12 7:29 ` Rémi Denis-Courmont
2020-12-18 10:37 ` [PATCH 15/18] target/arm: set HPFAR_EL2.NS on secure stage 2 faults remi.denis.courmont
2021-01-12 0:10 ` Richard Henderson
2020-12-18 10:37 ` [PATCH 16/18] target/arm: add ARMv8.4-SEL2 extension remi.denis.courmont
2021-01-12 0:13 ` Richard Henderson
2021-01-12 7:33 ` Rémi Denis-Courmont [this message]
2020-12-18 10:37 ` [PATCH 17/18] target/arm: enable Secure EL2 in max CPU remi.denis.courmont
2020-12-18 10:37 ` [PATCH 18/18] target/arm: refactor vae1_tlbmask() remi.denis.courmont
2021-01-12 0:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4284205.LvFx2qVVIh@basile.remlab.net \
--to=remi.denis.courmont@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).