From: yong.huang@smartx.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Hyman Huang" <yong.huang@smartx.com>,
dengpc12@chinatelecom.cn
Subject: [RFC 3/3] vdagent: Drop blocker to support migration
Date: Fri, 21 Mar 2025 11:38:13 +0800 [thread overview]
Message-ID: <428847678b4d47b4469236da2d888db18cc4c31c.1742527956.git.yong.huang@smartx.com> (raw)
In-Reply-To: <cover.1742527956.git.yong.huang@smartx.com>
From: Hyman Huang <yong.huang@smartx.com>
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
---
ui/vdagent.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/ui/vdagent.c b/ui/vdagent.c
index 4635e8fa56..36b0568135 100644
--- a/ui/vdagent.c
+++ b/ui/vdagent.c
@@ -6,7 +6,6 @@
#include "qemu/option.h"
#include "qemu/units.h"
#include "hw/qdev-core.h"
-#include "migration/blocker.h"
#include "migration/vmstate.h"
#include "ui/clipboard.h"
#include "ui/console.h"
@@ -33,9 +32,6 @@
struct VDAgentChardev {
Chardev parent;
- /* TODO: migration isn't yet supported */
- Error *migration_blocker;
-
/* config */
bool mouse;
bool clipboard;
@@ -673,10 +669,6 @@ static void vdagent_chr_open(Chardev *chr,
return;
#endif
- if (migrate_add_blocker(&vd->migration_blocker, errp) != 0) {
- return;
- }
-
vd->mouse = VDAGENT_MOUSE_DEFAULT;
if (cfg->has_mouse) {
vd->mouse = cfg->mouse;
@@ -998,15 +990,12 @@ static void vdagent_chr_init(Object *obj)
buffer_init(&vd->outbuf, "vdagent-outbuf");
vmstate_register(NULL, 0, &vmstate_vdagent, vd);
- error_setg(&vd->migration_blocker,
- "The vdagent chardev doesn't yet support migration");
}
static void vdagent_chr_fini(Object *obj)
{
VDAgentChardev *vd = QEMU_VDAGENT_CHARDEV(obj);
- migrate_del_blocker(&vd->migration_blocker);
vdagent_disconnect(vd);
if (vd->mouse_hs) {
qemu_input_handler_unregister(vd->mouse_hs);
--
2.27.0
next prev parent reply other threads:[~2025-03-21 3:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 3:38 [RFC 0/3] Support live migration for qemu-vdagent chardev yong.huang
2025-03-21 3:38 ` [RFC 1/3] vdagent: Wrap vdagent_register_to_qemu_clipboard function yong.huang
2025-03-21 3:38 ` [RFC 2/3] vdagent: Set up mouse and clipboard after live migration yong.huang
2025-03-21 3:38 ` yong.huang [this message]
2025-03-21 6:41 ` [RFC 0/3] Support live migration for qemu-vdagent chardev Marc-André Lureau
2025-03-21 7:29 ` Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428847678b4d47b4469236da2d888db18cc4c31c.1742527956.git.yong.huang@smartx.com \
--to=yong.huang@smartx.com \
--cc=dengpc12@chinatelecom.cn \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).