* [Qemu-devel] There is a bug in ppc_prep.c?
@ 2005-05-22 19:07 Tero Kaarlela
2005-05-23 10:48 ` J. Mayer
0 siblings, 1 reply; 2+ messages in thread
From: Tero Kaarlela @ 2005-05-22 19:07 UTC (permalink / raw)
To: qemu-devel
Hi,
I just browsed CVS repository and found following from ppc_prep.c:
/* Check LE mode */
if (val & 0x02) {
printf("Little Endian mode isn't supported (yet ?)\n");
abort();
shouldnt this be ie:
/* Check LE mode */
if (val & 0x02) {
printf("Switching to Little Endian mode...");
/* abort(); */
?
Tero Kaarlela
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] There is a bug in ppc_prep.c?
2005-05-22 19:07 [Qemu-devel] There is a bug in ppc_prep.c? Tero Kaarlela
@ 2005-05-23 10:48 ` J. Mayer
0 siblings, 0 replies; 2+ messages in thread
From: J. Mayer @ 2005-05-23 10:48 UTC (permalink / raw)
To: qemu-devel
On Sun, 2005-05-22 at 22:07 +0300, Tero Kaarlela wrote:
> Hi,
>
> I just browsed CVS repository and found following from ppc_prep.c:
>
>
>
> /* Check LE mode */
> if (val & 0x02) {
> printf("Little Endian mode isn't supported (yet ?)\n");
> abort();
>
> shouldnt this be ie:
>
> /* Check LE mode */
> if (val & 0x02) {
> printf("Switching to Little Endian mode...");
> /* abort(); */
>
>
> ?
This is supposed to be needed for endian mode switch. However, we have
seen with OS/2 that it would be needed to do nothing when this bit is
set, then I'd prefer to do nothing: that only means, imho, that we don't
know what need to be swapped. Then I'd better not have the feature than
do sthing that I know is a bug (ie does not correspond to platform
specification).
Then, I did let this untouched in the repository.
--
J. Mayer <l_indien@magic.fr>
Never organized
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-23 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-22 19:07 [Qemu-devel] There is a bug in ppc_prep.c? Tero Kaarlela
2005-05-23 10:48 ` J. Mayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).