From: Paolo Bonzini <pbonzini@redhat.com>
To: Luwei Kang <luwei.kang@intel.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, rth@twiddle.net
Subject: Re: [PATCH] target/i386: Correct the warning message of Intel PT
Date: Wed, 1 Jul 2020 16:21:51 +0200 [thread overview]
Message-ID: <4292eab0-9a6b-80f8-2b90-4e2d9c4214a4@redhat.com> (raw)
In-Reply-To: <1593499113-4768-1-git-send-email-luwei.kang@intel.com>
On 30/06/20 08:38, Luwei Kang wrote:
> The CPUID level need to be set to 0x14 manually on old
> machine-type if Intel PT is enabled in guest. E.g. the
> CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the
> Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter.
>
> This patch corrects the warning message of the previous
> submission(ddc2fc9).
>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 90ffc5f..a0e39d1 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -6375,7 +6375,7 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
> } else if (cpu->env.cpuid_min_level < 0x14) {
> mark_unavailable_features(cpu, FEAT_7_0_EBX,
> CPUID_7_0_EBX_INTEL_PT,
> - "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,level=0x14\"");
> + "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,min-level=0x14\"");
> }
> }
>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-07-01 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:38 [PATCH] target/i386: Correct the warning message of Intel PT Luwei Kang
2020-07-01 14:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4292eab0-9a6b-80f8-2b90-4e2d9c4214a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=luwei.kang@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).