From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF15C02194 for ; Tue, 4 Feb 2025 18:17:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tfNTZ-0006qN-C7; Tue, 04 Feb 2025 13:16:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfNTX-0006p2-Lj for qemu-devel@nongnu.org; Tue, 04 Feb 2025 13:16:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfNTW-0008NN-2D for qemu-devel@nongnu.org; Tue, 04 Feb 2025 13:16:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738693000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dxEy0E6KZF4fY89Y0kh3AOoKSXRhbtiOt8I8jlSzR5k=; b=bNFPUIJyLj03JAacyUD7FKeO6ouwe4nk2dplY5NA1jSBOytoTqaTJjObsarCT7aR+3NVu0 v0MyJya0rBTs17OmypnTOVAbw1mbx27B1wQdx0p6OH3Xl15tT0gNZiZIFfbkYPb61INNZf zaAyD2SySs4fc5uRRiQbtXLrH9HLM7k= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-KSegb4wMNnCYMUAuwszBMg-1; Tue, 04 Feb 2025 13:16:38 -0500 X-MC-Unique: KSegb4wMNnCYMUAuwszBMg-1 X-Mimecast-MFC-AGG-ID: KSegb4wMNnCYMUAuwszBMg Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5d9e4d33f04so5945918a12.0 for ; Tue, 04 Feb 2025 10:16:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738692997; x=1739297797; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dxEy0E6KZF4fY89Y0kh3AOoKSXRhbtiOt8I8jlSzR5k=; b=L1TfzsJHmszg8EPLkoBtt92Lb3rHsmQDa8d3MH1VB8LHk+7J7+iGGzWn94zuOqLIgk DvQZjzzfx2UmXRA+VdZ042LFaNnlej5a1dBTRBuDf4PZR269whp46JPjlKl+OshAXmR7 BSnXuY/jGpmm3eGUiqiiRq6///Onu967tdWJXchXaL3+HY2rS+MOy3JhNDBVbM4T1d0O LsapqwoT2OMHxzdt+ODHHec3iT+0/jmlms2TUjDT5Y4ZIHkPGuFQTVyJ4sFkYiEv/F39 G9uozhQB9R701+EzrIFi4a+eYDSgU454sh3IO2IDiGMd4WsFDmPd0JIuuik9daO4+7++ RQlA== X-Forwarded-Encrypted: i=1; AJvYcCXuAjM1Dp0avlfdjjQ4xAe4cK0x+8uwaanOTnqY3rWBl2gbwb4Fx4vNH0iDR/g8geCgWUGbESmr5aFK@nongnu.org X-Gm-Message-State: AOJu0Yz4bsXDRVi3MflSrKpAXJ9AC1Rq5YdtimB2dvIwzrfnRVXtvIEv t38xT5LjLAvRfGFQcj03PZqzEa/4fZBgtCqejRqXH2pP6nhdrR2FMrLPKXnYbbKjVSgbQWZlF3S VeKO+Rl8PF7v9iHeDccT5Gf4VQPS6IxZq5M9jmO3ZBkN0XciyxIIu X-Gm-Gg: ASbGncv+BhxneJvzwqXhL0/bDRxOFwhE/oJoKskYROYtrNu1jQh8isq6QaHldXLf8zY eTLF5lePDFIzPTabGlQf7ftGDSyYg/cL2c4ak9gfTtHvwgAS8BmE1P1Cg7eccVz0ZF+5APMv+zG 3rp96/GZqmTkW7hhndv4uu+vKK+54wAhg4vX0ZOQxYRoP0RFEHX9L2uKLgWs6HdeDoWrMKotiTX uLbVZ3U+FTZqru/luN5rogs4ZoZ2eIcVthHA4Jg64VnALFFYS4mseIIb4w2GmR6ZPw5xhCcSTz/ zbGb5HQpMy6MPFgcul4fniMMw5HXIbh9BKbv X-Received: by 2002:a05:6402:2687:b0:5dc:db28:6afc with SMTP id 4fb4d7f45d1cf-5dcdb57fb04mr79139a12.0.1738692997524; Tue, 04 Feb 2025 10:16:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHBcHQPDC8IKSuANj4px3X/xB1jPH11LzBx1/y0trHyhpX+ltzumjMSpgpoA2MSSs3OIwmLQ== X-Received: by 2002:a05:6402:2687:b0:5dc:db28:6afc with SMTP id 4fb4d7f45d1cf-5dcdb57fb04mr79114a12.0.1738692997196; Tue, 04 Feb 2025 10:16:37 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-48-132.web.vodafone.de. [109.42.48.132]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dcda03eaecsm214335a12.49.2025.02.04.10.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 10:16:36 -0800 (PST) Message-ID: <42950b71-264c-48e2-96d1-5ce4d0990e64@redhat.com> Date: Tue, 4 Feb 2025 19:16:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Peter Maydell , qemu-ppc@nongnu.org, =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Paolo Bonzini , qemu-s390x@nongnu.org, Markus Armbruster References: <20250204180746.58357-1-philmd@linaro.org> <20250204180746.58357-3-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250204180746.58357-3-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 04/02/2025 19.07, Philippe Mathieu-Daudé wrote: > Update MachineClass::no_sdcard default implicit AUTO > initialization to explicit OFF. This flag is consumed > in system/vl.c::qemu_disable_default_devices(). Use > this place to assert we don't have anymore AUTO state. > > In hw/ppc/e500.c we add the ppce500_machine_class_init() > method to initialize once all the inherited classes. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > --- ... > diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c > index 12418094f9d..dc80181ea43 100644 > --- a/hw/arm/xilinx_zynq.c > +++ b/hw/arm/xilinx_zynq.c > @@ -467,6 +467,7 @@ static void zynq_machine_class_init(ObjectClass *oc, void *data) > mc->ignore_memory_transaction_failures = true; > mc->valid_cpu_types = valid_cpu_types; > mc->default_ram_id = "zynq.ext_ram"; > + mc->no_sdcard = ON_OFF_AUTO_OFF; > prop = object_class_property_add_str(oc, "boot-mode", NULL, > zynq_set_boot_mode); > object_class_property_set_description(oc, "boot-mode", This hunk seems to be wrong since the previous patch already sets no_sdcard to ON here? Thomas