From: Richard Henderson <richard.henderson@linaro.org>
To: "Laurent Vivier" <laurent@vivier.eu>,
"Taylor Simpson" <tsimpson@quicinc.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"riku.voipio@iki.fi" <riku.voipio@iki.fi>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards
Date: Wed, 20 Nov 2019 10:02:06 +0100 [thread overview]
Message-ID: <42954e4f-11cd-6c95-e74c-9dbec2f90d56@linaro.org> (raw)
In-Reply-To: <98464579-194a-2b96-5cb9-3b7a7d9e680d@vivier.eu>
On 11/20/19 9:33 AM, Laurent Vivier wrote:
> Le 20/11/2019 à 05:48, Taylor Simpson a écrit :
>> For the general DEBUG_HEX messages, I think the trace infrastructure isn't quite what I'm looking for.
>>
>> Here's a sample of what it prints
>> Start packet: pc = 0x4002f0
>> Packet committed: pc = 0x4002f0
>> Regs written
>> r18 = -69420 (0xfffef0d4)
>> r19 = -69412 (0xfffef0dc)
>> Stores
>> memd[0xfffef0b0] = 0 (0x0000000000000000)
>> Next PC = 0x4002f8
>> Exec counters: pkt = 17, insn = 24, hvx = 0
For something like this, I'd keep DEBUG_HEX.
>> if (qemu_loglevel_maks(CPU_LOG_EXEC)) {
CPU_LOG_EXEC already has a specific structure, listing
the TranslationBlocks that are executed. It shouldn't
be hijacked for something else.
If you really want a runtime flag for this, we should
add a new CPU_LOG_* flag.
r~
next prev parent reply other threads:[~2019-11-20 9:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 23:58 [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards Taylor Simpson
2019-11-19 1:31 ` no-reply
2019-11-19 8:51 ` Exclude paths from checkpatch (was: Re: [PATCH] Add minimal Hexagon target) Philippe Mathieu-Daudé
2019-11-19 13:33 ` Richard Henderson
2019-11-19 15:37 ` Paolo Bonzini
2019-11-19 16:14 ` Stefan Hajnoczi
2019-11-19 8:39 ` [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards Laurent Vivier
2019-11-19 9:03 ` Laurent Vivier
2019-11-19 14:14 ` Eric Blake
2019-11-19 15:11 ` Philippe Mathieu-Daudé
2019-11-19 15:19 ` Philippe Mathieu-Daudé
2019-11-19 17:22 ` Taylor Simpson
2019-11-19 17:32 ` Peter Maydell
2019-11-19 18:13 ` Laurent Vivier
2019-11-20 4:48 ` Taylor Simpson
2019-11-20 8:33 ` Laurent Vivier
2019-11-20 9:02 ` Richard Henderson [this message]
2019-11-20 12:58 ` Taylor Simpson
2019-11-20 14:14 ` Laurent Vivier
2019-11-20 15:19 ` Taylor Simpson
2019-11-20 16:40 ` Alex Bennée
2019-11-20 17:09 ` Philippe Mathieu-Daudé
2019-11-19 19:36 ` Richard Henderson
2019-11-20 2:26 ` Aleksandar Markovic
2019-11-20 7:49 ` Richard Henderson
2019-11-21 6:01 ` Aleksandar Markovic
2019-11-21 8:55 ` Richard Henderson
2019-11-20 8:41 ` Laurent Vivier
2019-11-20 17:34 ` Alex Bennée
2019-11-19 19:33 ` Richard Henderson
2019-11-20 5:15 ` Taylor Simpson
2019-11-20 8:06 ` Richard Henderson
2019-11-20 12:51 ` Taylor Simpson
2019-11-20 14:43 ` Richard Henderson
2019-11-20 15:17 ` Taylor Simpson
2019-11-21 9:00 ` Richard Henderson
2019-11-21 19:20 ` Aleksandar Markovic
2019-11-21 19:52 ` Taylor Simpson
2019-11-21 20:44 ` Aleksandar Markovic
2019-11-21 23:51 ` Taylor Simpson
2019-11-22 9:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42954e4f-11cd-6c95-e74c-9dbec2f90d56@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).