From: Eric Auger <eric.auger@redhat.com>
To: Gustavo Romero <gustavo.romero@linaro.org>,
qemu-devel@nongnu.org, philmd@linaro.org, mst@redhat.com
Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, udo@hypervisor.org,
ajones@ventanamicro.com, peter.maydell@linaro.org,
imammedo@redhat.com, anisinha@redhat.com
Subject: Re: [PATCH v5 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64
Date: Fri, 27 Jun 2025 17:49:44 +0200 [thread overview]
Message-ID: <4299cd13-f319-46f4-a36d-6ec1ff8169bd@redhat.com> (raw)
In-Reply-To: <20250623135749.691137-10-gustavo.romero@linaro.org>
Hi Gustavo,
On 6/23/25 3:57 PM, Gustavo Romero wrote:
> Update blobs for the its=off test on aarch64 after fix.
>
> Basically, all structs related to ITS are gone in MADT and IORT
> tables after the fix (previously ITS was not properly disabled
> when "its=off" option was passed to the machine).
>
> MADT diff:
>
> [000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
> -[004h 0004 4] Table Length : 000000B8
> +[004h 0004 4] Table Length : 000000A4
> [008h 0008 1] Revision : 04
> -[009h 0009 1] Checksum : C1
> +[009h 0009 1] Checksum : 08
> [00Ah 0010 6] Oem ID : "BOCHS "
> [010h 0016 8] Oem Table ID : "BXPC "
> [018h 0024 4] Oem Revision : 00000001
> [01Ch 0028 4] Asl Compiler ID : "BXPC"
> [020h 0032 4] Asl Compiler Revision : 00000001
>
> [024h 0036 4] Local Apic Address : 00000000
> [028h 0040 4] Flags (decoded below) : 00000000
> PC-AT Compatibility : 0
>
> [02Ch 0044 1] Subtable Type : 0C [Generic Interrupt Distributor]
> [02Dh 0045 1] Length : 18
> [02Eh 0046 2] Reserved : 0000
> [030h 0048 4] Local GIC Hardware ID : 00000000
> [034h 0052 8] Base Address : 0000000008000000
> [03Ch 0060 4] Interrupt Base : 00000000
> @@ -48,37 +48,29 @@
> [064h 0100 8] Base Address : 0000000000000000
> [06Ch 0108 8] Virtual GIC Base Address : 0000000000000000
> [074h 0116 8] Hypervisor GIC Base Address : 0000000000000000
> [07Ch 0124 4] Virtual GIC Interrupt : 00000000
> [080h 0128 8] Redistributor Base Address : 0000000000000000
> [088h 0136 8] ARM MPIDR : 0000000000000000
> [090h 0144 1] Efficiency Class : 00
> [091h 0145 1] Reserved : 00
> [092h 0146 2] SPE Overflow Interrupt : 0000
>
> [094h 0148 1] Subtable Type : 0E [Generic Interrupt Redistributor]
> [095h 0149 1] Length : 10
> [096h 0150 2] Reserved : 0000
> [098h 0152 8] Base Address : 00000000080A0000
> [0A0h 0160 4] Length : 00F60000
>
> -[0A4h 0164 1] Subtable Type : 0F [Generic Interrupt Translator]
> -[0A5h 0165 1] Length : 14
> -[0A6h 0166 2] Reserved : 0000
> -[0A8h 0168 4] Translation ID : 00000000
> -[0ACh 0172 8] Base Address : 0000000008080000
> -[0B4h 0180 4] Reserved : 00000000
>
> IORT diff:
>
> [000h 0000 4] Signature : "IORT" [IO Remapping Table]
> -[004h 0004 4] Table Length : 000000EC
> +[004h 0004 4] Table Length : 000000AC
> [008h 0008 1] Revision : 03
> -[009h 0009 1] Checksum : 57
> +[009h 0009 1] Checksum : 97
> [00Ah 0010 6] Oem ID : "BOCHS "
> [010h 0016 8] Oem Table ID : "BXPC "
> [018h 0024 4] Oem Revision : 00000001
> [01Ch 0028 4] Asl Compiler ID : "BXPC"
> [020h 0032 4] Asl Compiler Revision : 00000001
>
> -[024h 0036 4] Node Count : 00000003
> +[024h 0036 4] Node Count : 00000002
> [028h 0040 4] Node Offset : 00000030
> [02Ch 0044 4] Reserved : 00000000
>
> -[030h 0048 1] Type : 00
> -[031h 0049 2] Length : 0018
> -[033h 0051 1] Revision : 01
> +[030h 0048 1] Type : 04
> +[031h 0049 2] Length : 0044
> +[033h 0051 1] Revision : 04
> [034h 0052 4] Reserved : 00000000
> [038h 0056 4] Mapping Count : 00000000
> [03Ch 0060 4] Mapping Offset : 00000000
>
> -[040h 0064 4] ItsCount : 00000001
> -[044h 0068 4] Identifiers : 00000000
> -
> -[048h 0072 1] Type : 04
> -[049h 0073 2] Length : 0058
> -[04Bh 0075 1] Revision : 04
> -[04Ch 0076 4] Reserved : 00000001
> -[050h 0080 4] Mapping Count : 00000001
> -[054h 0084 4] Mapping Offset : 00000044
> -
> -[058h 0088 8] Base Address : 0000000009050000
> -[060h 0096 4] Flags (decoded below) : 00000001
> +[040h 0064 8] Base Address : 0000000009050000
> +[048h 0072 4] Flags (decoded below) : 00000001
> COHACC Override : 1
> HTTU Override : 0
> Proximity Domain Valid : 0
> -[064h 0100 4] Reserved : 00000000
> -[068h 0104 8] VATOS Address : 0000000000000000
> -[070h 0112 4] Model : 00000000
> -[074h 0116 4] Event GSIV : 0000006A
> -[078h 0120 4] PRI GSIV : 0000006B
> -[07Ch 0124 4] GERR GSIV : 0000006D
> -[080h 0128 4] Sync GSIV : 0000006C
> -[084h 0132 4] Proximity Domain : 00000000
> -[088h 0136 4] Device ID Mapping Index : 00000000
> -
> -[08Ch 0140 4] Input base : 00000000
> -[090h 0144 4] ID Count : 0000FFFF
> -[094h 0148 4] Output Base : 00000000
> -[098h 0152 4] Output Reference : 00000030
> -[09Ch 0156 4] Flags (decoded below) : 00000000
> - Single Mapping : 0
> -
> -[0A0h 0160 1] Type : 02
> -[0A1h 0161 2] Length : 004C
> -[0A3h 0163 1] Revision : 03
> -[0A4h 0164 4] Reserved : 00000002
> -[0A8h 0168 4] Mapping Count : 00000002
> -[0ACh 0172 4] Mapping Offset : 00000024
> -
> -[0B0h 0176 8] Memory Properties : [IORT Memory Access Properties]
> -[0B0h 0176 4] Cache Coherency : 00000001
> -[0B4h 0180 1] Hints (decoded below) : 00
> +[04Ch 0076 4] Reserved : 00000000
> +[050h 0080 8] VATOS Address : 0000000000000000
> +[058h 0088 4] Model : 00000000
> +[05Ch 0092 4] Event GSIV : 0000006A
> +[060h 0096 4] PRI GSIV : 0000006B
> +[064h 0100 4] GERR GSIV : 0000006D
> +[068h 0104 4] Sync GSIV : 0000006C
> +[06Ch 0108 4] Proximity Domain : 00000000
> +[070h 0112 4] Device ID Mapping Index : 00000000
> +
> +[074h 0116 1] Type : 02
> +[075h 0117 2] Length : 0038
> +[077h 0119 1] Revision : 03
> +[078h 0120 4] Reserved : 00000001
> +[07Ch 0124 4] Mapping Count : 00000001
> +[080h 0128 4] Mapping Offset : 00000024
> +
> +[084h 0132 8] Memory Properties : [IORT Memory Access Properties]
> +[084h 0132 4] Cache Coherency : 00000001
> +[088h 0136 1] Hints (decoded below) : 00
> Transient : 0
> Write Allocate : 0
> Read Allocate : 0
> Override : 0
> -[0B5h 0181 2] Reserved : 0000
> -[0B7h 0183 1] Memory Flags (decoded below) : 03
> +[089h 0137 2] Reserved : 0000
> +[08Bh 0139 1] Memory Flags (decoded below) : 03
> Coherency : 1
> Device Attribute : 1
> -[0B8h 0184 4] ATS Attribute : 00000000
> -[0BCh 0188 4] PCI Segment Number : 00000000
> -[0C0h 0192 1] Memory Size Limit : 40
> -[0C1h 0193 3] Reserved : 000000
> -
> -[0C4h 0196 4] Input base : 00000000
> -[0C8h 0200 4] ID Count : 000000FF
> -[0CCh 0204 4] Output Base : 00000000
> -[0D0h 0208 4] Output Reference : 00000048
> -[0D4h 0212 4] Flags (decoded below) : 00000000
> - Single Mapping : 0
> -
> -[0D8h 0216 4] Input base : 00000100
> -[0DCh 0220 4] ID Count : 0000FEFF
> -[0E0h 0224 4] Output Base : 00000100
> -[0E4h 0228 4] Output Reference : 00000030
> -[0E8h 0232 4] Flags (decoded below) : 00000000
> +[08Ch 0140 4] ATS Attribute : 00000000
> +[090h 0144 4] PCI Segment Number : 00000000
> +[094h 0148 1] Memory Size Limit : 40
> +[095h 0149 3] Reserved : 000000
> +
> +[098h 0152 4] Input base : 00000000
> +[09Ch 0156 4] ID Count : 000000FF
> +[0A0h 0160 4] Output Base : 00000000
> +[0A4h 0164 4] Output Reference : 00000030
> +[0A8h 0168 4] Flags (decoded below) : 00000000
> Single Mapping : 0
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> tests/data/acpi/aarch64/virt/APIC.its_off | Bin 184 -> 164 bytes
> tests/data/acpi/aarch64/virt/IORT.its_off | Bin 236 -> 172 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 2 --
> 3 files changed, 2 deletions(-)
>
> diff --git a/tests/data/acpi/aarch64/virt/APIC.its_off b/tests/data/acpi/aarch64/virt/APIC.its_off
> index 37d82e970b1331cb5b259f0bd2d3654bacb2d623..6130cb7d07103b326feb4dcd7034f85808bebadf 100644
> GIT binary patch
> delta 18
> ZcmdnNxP+0*F~HM#2?GNI3&%vRSpY2+1Zw~Q
>
> delta 39
> jcmZ3&xPy_)F~HM#2Ll5G%fX3UvqbnsfJ`vp;DE6JqX7kf
>
> diff --git a/tests/data/acpi/aarch64/virt/IORT.its_off b/tests/data/acpi/aarch64/virt/IORT.its_off
> index 0fceb820d509e852ca0849baf568a8e93e426738..c10da4e61dd00e7eb062558a2735d49ca0b20620 100644
> GIT binary patch
> delta 69
> zcmaFExQ3C-(?2L=4FdxM^Yn>aQj$zSmH`lh0E-I)3xowECx)7HGFdP%GXmL+6IZHp
> Hz*GSMclZc%
>
> literal 236
> zcmebD4+?q1z`(#9?&R<65v<@85#X!<1dKp25F11@1F-=RgMkDCNC*yK9F_<M77!bR
> zUBI%eoFED&4;F$FSwK1)h;xBB2Py`m{{M%tVD>TjFfcO#g+N#Zh@s|zoCF3AP#UU@
> R!2`+%Dg6Hr$N|zYvjDIZ5CH%H
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index a88198d5c2..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,3 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/aarch64/virt/APIC.its_off",
> -"tests/data/acpi/aarch64/virt/IORT.its_off",
prev parent reply other threads:[~2025-06-27 15:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 13:57 [PATCH-for-10.1 v5 0/9] hw/arm: GIC 'its=off' ACPI table fixes Gustavo Romero
2025-06-23 13:57 ` [PATCH v5 1/9] hw/intc/gicv3_its: Do not check its_class_name() Gustavo Romero
2025-06-23 13:57 ` [PATCH v5 2/9] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable Gustavo Romero
2025-06-23 13:57 ` [PATCH v5 3/9] hw/arm/virt: Simplify create_its() Gustavo Romero
2025-06-23 13:57 ` [PATCH v5 4/9] hw/arm/virt-acpi-build: Improve comment in build_iort Gustavo Romero
2025-06-27 13:57 ` Eric Auger
2025-06-27 14:05 ` Eric Auger via
2025-06-23 13:57 ` [PATCH v5 5/9] hw/arm/virt-acpi-build: Factor out create_its_idmaps Gustavo Romero
2025-06-27 15:28 ` Eric Auger
2025-06-28 19:43 ` Gustavo Romero
2025-06-23 13:57 ` [PATCH v5 6/9] qtest/bios-tables-test: Add test for when ITS is off on aarch64 Gustavo Romero
2025-06-27 15:30 ` Eric Auger
2025-06-23 13:57 ` [PATCH v5 7/9] qtest/bios-tables-test: Add blobs for its=off test " Gustavo Romero
2025-06-27 15:32 ` Eric Auger
2025-06-23 13:57 ` [PATCH v5 8/9] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off Gustavo Romero
2025-06-27 15:44 ` Eric Auger
2025-06-28 19:44 ` Gustavo Romero
2025-06-27 15:45 ` Eric Auger
2025-06-27 15:46 ` Eric Auger via
2025-06-23 13:57 ` [PATCH v5 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64 Gustavo Romero
2025-06-27 15:49 ` Eric Auger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4299cd13-f319-46f4-a36d-6ec1ff8169bd@redhat.com \
--to=eric.auger@redhat.com \
--cc=ajones@ventanamicro.com \
--cc=alex.bennee@linaro.org \
--cc=anisinha@redhat.com \
--cc=gustavo.romero@linaro.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=udo@hypervisor.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).