From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7148FC7EE2A for ; Fri, 27 Jun 2025 15:50:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uVBKu-0006Pi-3I; Fri, 27 Jun 2025 11:49:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVBKr-0006P7-MO for qemu-devel@nongnu.org; Fri, 27 Jun 2025 11:49:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uVBKp-0000Ht-Hm for qemu-devel@nongnu.org; Fri, 27 Jun 2025 11:49:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751039390; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xoxZLRWQq7WcffEgcQI6eAf7Lp4ELIC4XJ0R8S07HI=; b=aiE0t+VuGTsskz5g2EnecKNjnSFYO1L572K/qk2+H13+043N2VUt06a0UZbGmDY51+OHaD f0fymbPU90jZXFoUoLJMvfTLWYN8Ml9/qD+j2/AXv6MiEE9S0l4+jaxti0QP0yhgjSJXXu Y31zhshDL0cFEX1yH6rqjKaW9ftIoEQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-CfxQmQaBNBOJlWG2eE40Uw-1; Fri, 27 Jun 2025 11:49:48 -0400 X-MC-Unique: CfxQmQaBNBOJlWG2eE40Uw-1 X-Mimecast-MFC-AGG-ID: CfxQmQaBNBOJlWG2eE40Uw_1751039387 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-453018b4ddeso13320455e9.3 for ; Fri, 27 Jun 2025 08:49:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751039387; x=1751644187; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7xoxZLRWQq7WcffEgcQI6eAf7Lp4ELIC4XJ0R8S07HI=; b=KUjN9hX+ZnQ+emr2aeYwZjZS5BgPYEZetwrEEqTfb95hNGLeFFYSPSnRxm+1A+ah4N eDb0bFBbneK0Ql8Yq75xlGGE1VXPBrZJDvlYTmi5dPhu5sWZn218A3P7vQ1NfpKrIooG a0LUNK95lL7ivQNwHV3hp4Lhq4HxeAZbvSeoRF69buqP0RNvbSdSkSFum32cQAn806kx TUP/z/T/ngRET++5b7BIPFJBIsDgHWQKO/HatHi7XbawiN7OjRUgFFo+ZPuJKi1/IEA1 72AsX8nQyh62rIzo+BlQxxGIySq9MU8f+4+snMFs/kSLkUo/H2WHOUuYHRK0Jg9C4uB3 aOqw== X-Forwarded-Encrypted: i=1; AJvYcCWH6SD/Z53lqXKBNwgZaHFInChn8Hjd8yJ0Hz3wLMQyA/4kjG8bV8FpL+ldN692et93LqjjzbgQ0m//@nongnu.org X-Gm-Message-State: AOJu0YzXRmhmIMWqssp0lLP8G4WWdXGPwb04ZVDiSFgGGL597OulRGvh Rfq65L+rtEiltSkVlJH64NjWUGgWno3kF7u9qDe9vf5zNBs4cph0udoi85GByWfNOV07VncKyhg pF1QbstxQLgQeabLU015YwCUDqvaCGfHOxpAxmqwAvj+r4D+Y1eRRV2Cr X-Gm-Gg: ASbGncs9L9Vt/WKvxIM5v1tbdjImOscWZRtODcxAxwBy62FZcH+L9qDS4c3oDl+3YwH He76EVjpEmVqQORU2IC8WOxnK8R3y67BCjiLZ6k1rc7O9qHJIm+2q7qmWfZ1E7KR2H5TMxFjv1N Jw6IKXQUzDoLhvKUIu4O3VYRhBiiOT5dy6w3IuM6Cn23+eXXKjrhYRpoARZIzsMIgQOT/tQTNGa SlR6D+BwPVsD5PZaD5fd/B7sFrqv7AXuI2hsaLkGB+85sjmJlM5lXPQnhmAWrQGrzCmaqi/G6xC oC6vp/3kO5LlNmySZW4HppozJVE7ICLkAoc7uc3hJZEMGM23h/fsQO42FPWVUz+W66Hy8Q== X-Received: by 2002:a05:600c:c4ac:b0:442:d9fc:7de with SMTP id 5b1f17b1804b1-4538ee85615mr37712325e9.22.1751039387154; Fri, 27 Jun 2025 08:49:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzJGkLKlExXl0e4ZsEnR8/AqRMWJSuL6ZtqOKhsyxNNQCDLoXV8kxkePxmVJwc7UW+NREUVw== X-Received: by 2002:a05:600c:c4ac:b0:442:d9fc:7de with SMTP id 5b1f17b1804b1-4538ee85615mr37712035e9.22.1751039386588; Fri, 27 Jun 2025 08:49:46 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e59628sm2982549f8f.81.2025.06.27.08.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 08:49:45 -0700 (PDT) Message-ID: <4299cd13-f319-46f4-a36d-6ec1ff8169bd@redhat.com> Date: Fri, 27 Jun 2025 17:49:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64 Content-Language: en-US To: Gustavo Romero , qemu-devel@nongnu.org, philmd@linaro.org, mst@redhat.com Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, udo@hypervisor.org, ajones@ventanamicro.com, peter.maydell@linaro.org, imammedo@redhat.com, anisinha@redhat.com References: <20250623135749.691137-1-gustavo.romero@linaro.org> <20250623135749.691137-10-gustavo.romero@linaro.org> From: Eric Auger In-Reply-To: <20250623135749.691137-10-gustavo.romero@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Gustavo, On 6/23/25 3:57 PM, Gustavo Romero wrote: > Update blobs for the its=off test on aarch64 after fix. > > Basically, all structs related to ITS are gone in MADT and IORT > tables after the fix (previously ITS was not properly disabled > when "its=off" option was passed to the machine). > > MADT diff: > > [000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)] > -[004h 0004 4] Table Length : 000000B8 > +[004h 0004 4] Table Length : 000000A4 > [008h 0008 1] Revision : 04 > -[009h 0009 1] Checksum : C1 > +[009h 0009 1] Checksum : 08 > [00Ah 0010 6] Oem ID : "BOCHS " > [010h 0016 8] Oem Table ID : "BXPC " > [018h 0024 4] Oem Revision : 00000001 > [01Ch 0028 4] Asl Compiler ID : "BXPC" > [020h 0032 4] Asl Compiler Revision : 00000001 > > [024h 0036 4] Local Apic Address : 00000000 > [028h 0040 4] Flags (decoded below) : 00000000 > PC-AT Compatibility : 0 > > [02Ch 0044 1] Subtable Type : 0C [Generic Interrupt Distributor] > [02Dh 0045 1] Length : 18 > [02Eh 0046 2] Reserved : 0000 > [030h 0048 4] Local GIC Hardware ID : 00000000 > [034h 0052 8] Base Address : 0000000008000000 > [03Ch 0060 4] Interrupt Base : 00000000 > @@ -48,37 +48,29 @@ > [064h 0100 8] Base Address : 0000000000000000 > [06Ch 0108 8] Virtual GIC Base Address : 0000000000000000 > [074h 0116 8] Hypervisor GIC Base Address : 0000000000000000 > [07Ch 0124 4] Virtual GIC Interrupt : 00000000 > [080h 0128 8] Redistributor Base Address : 0000000000000000 > [088h 0136 8] ARM MPIDR : 0000000000000000 > [090h 0144 1] Efficiency Class : 00 > [091h 0145 1] Reserved : 00 > [092h 0146 2] SPE Overflow Interrupt : 0000 > > [094h 0148 1] Subtable Type : 0E [Generic Interrupt Redistributor] > [095h 0149 1] Length : 10 > [096h 0150 2] Reserved : 0000 > [098h 0152 8] Base Address : 00000000080A0000 > [0A0h 0160 4] Length : 00F60000 > > -[0A4h 0164 1] Subtable Type : 0F [Generic Interrupt Translator] > -[0A5h 0165 1] Length : 14 > -[0A6h 0166 2] Reserved : 0000 > -[0A8h 0168 4] Translation ID : 00000000 > -[0ACh 0172 8] Base Address : 0000000008080000 > -[0B4h 0180 4] Reserved : 00000000 > > IORT diff: > > [000h 0000 4] Signature : "IORT" [IO Remapping Table] > -[004h 0004 4] Table Length : 000000EC > +[004h 0004 4] Table Length : 000000AC > [008h 0008 1] Revision : 03 > -[009h 0009 1] Checksum : 57 > +[009h 0009 1] Checksum : 97 > [00Ah 0010 6] Oem ID : "BOCHS " > [010h 0016 8] Oem Table ID : "BXPC " > [018h 0024 4] Oem Revision : 00000001 > [01Ch 0028 4] Asl Compiler ID : "BXPC" > [020h 0032 4] Asl Compiler Revision : 00000001 > > -[024h 0036 4] Node Count : 00000003 > +[024h 0036 4] Node Count : 00000002 > [028h 0040 4] Node Offset : 00000030 > [02Ch 0044 4] Reserved : 00000000 > > -[030h 0048 1] Type : 00 > -[031h 0049 2] Length : 0018 > -[033h 0051 1] Revision : 01 > +[030h 0048 1] Type : 04 > +[031h 0049 2] Length : 0044 > +[033h 0051 1] Revision : 04 > [034h 0052 4] Reserved : 00000000 > [038h 0056 4] Mapping Count : 00000000 > [03Ch 0060 4] Mapping Offset : 00000000 > > -[040h 0064 4] ItsCount : 00000001 > -[044h 0068 4] Identifiers : 00000000 > - > -[048h 0072 1] Type : 04 > -[049h 0073 2] Length : 0058 > -[04Bh 0075 1] Revision : 04 > -[04Ch 0076 4] Reserved : 00000001 > -[050h 0080 4] Mapping Count : 00000001 > -[054h 0084 4] Mapping Offset : 00000044 > - > -[058h 0088 8] Base Address : 0000000009050000 > -[060h 0096 4] Flags (decoded below) : 00000001 > +[040h 0064 8] Base Address : 0000000009050000 > +[048h 0072 4] Flags (decoded below) : 00000001 > COHACC Override : 1 > HTTU Override : 0 > Proximity Domain Valid : 0 > -[064h 0100 4] Reserved : 00000000 > -[068h 0104 8] VATOS Address : 0000000000000000 > -[070h 0112 4] Model : 00000000 > -[074h 0116 4] Event GSIV : 0000006A > -[078h 0120 4] PRI GSIV : 0000006B > -[07Ch 0124 4] GERR GSIV : 0000006D > -[080h 0128 4] Sync GSIV : 0000006C > -[084h 0132 4] Proximity Domain : 00000000 > -[088h 0136 4] Device ID Mapping Index : 00000000 > - > -[08Ch 0140 4] Input base : 00000000 > -[090h 0144 4] ID Count : 0000FFFF > -[094h 0148 4] Output Base : 00000000 > -[098h 0152 4] Output Reference : 00000030 > -[09Ch 0156 4] Flags (decoded below) : 00000000 > - Single Mapping : 0 > - > -[0A0h 0160 1] Type : 02 > -[0A1h 0161 2] Length : 004C > -[0A3h 0163 1] Revision : 03 > -[0A4h 0164 4] Reserved : 00000002 > -[0A8h 0168 4] Mapping Count : 00000002 > -[0ACh 0172 4] Mapping Offset : 00000024 > - > -[0B0h 0176 8] Memory Properties : [IORT Memory Access Properties] > -[0B0h 0176 4] Cache Coherency : 00000001 > -[0B4h 0180 1] Hints (decoded below) : 00 > +[04Ch 0076 4] Reserved : 00000000 > +[050h 0080 8] VATOS Address : 0000000000000000 > +[058h 0088 4] Model : 00000000 > +[05Ch 0092 4] Event GSIV : 0000006A > +[060h 0096 4] PRI GSIV : 0000006B > +[064h 0100 4] GERR GSIV : 0000006D > +[068h 0104 4] Sync GSIV : 0000006C > +[06Ch 0108 4] Proximity Domain : 00000000 > +[070h 0112 4] Device ID Mapping Index : 00000000 > + > +[074h 0116 1] Type : 02 > +[075h 0117 2] Length : 0038 > +[077h 0119 1] Revision : 03 > +[078h 0120 4] Reserved : 00000001 > +[07Ch 0124 4] Mapping Count : 00000001 > +[080h 0128 4] Mapping Offset : 00000024 > + > +[084h 0132 8] Memory Properties : [IORT Memory Access Properties] > +[084h 0132 4] Cache Coherency : 00000001 > +[088h 0136 1] Hints (decoded below) : 00 > Transient : 0 > Write Allocate : 0 > Read Allocate : 0 > Override : 0 > -[0B5h 0181 2] Reserved : 0000 > -[0B7h 0183 1] Memory Flags (decoded below) : 03 > +[089h 0137 2] Reserved : 0000 > +[08Bh 0139 1] Memory Flags (decoded below) : 03 > Coherency : 1 > Device Attribute : 1 > -[0B8h 0184 4] ATS Attribute : 00000000 > -[0BCh 0188 4] PCI Segment Number : 00000000 > -[0C0h 0192 1] Memory Size Limit : 40 > -[0C1h 0193 3] Reserved : 000000 > - > -[0C4h 0196 4] Input base : 00000000 > -[0C8h 0200 4] ID Count : 000000FF > -[0CCh 0204 4] Output Base : 00000000 > -[0D0h 0208 4] Output Reference : 00000048 > -[0D4h 0212 4] Flags (decoded below) : 00000000 > - Single Mapping : 0 > - > -[0D8h 0216 4] Input base : 00000100 > -[0DCh 0220 4] ID Count : 0000FEFF > -[0E0h 0224 4] Output Base : 00000100 > -[0E4h 0228 4] Output Reference : 00000030 > -[0E8h 0232 4] Flags (decoded below) : 00000000 > +[08Ch 0140 4] ATS Attribute : 00000000 > +[090h 0144 4] PCI Segment Number : 00000000 > +[094h 0148 1] Memory Size Limit : 40 > +[095h 0149 3] Reserved : 000000 > + > +[098h 0152 4] Input base : 00000000 > +[09Ch 0156 4] ID Count : 000000FF > +[0A0h 0160 4] Output Base : 00000000 > +[0A4h 0164 4] Output Reference : 00000030 > +[0A8h 0168 4] Flags (decoded below) : 00000000 > Single Mapping : 0 > > Signed-off-by: Gustavo Romero Reviewed-by: Eric Auger Eric > --- > tests/data/acpi/aarch64/virt/APIC.its_off | Bin 184 -> 164 bytes > tests/data/acpi/aarch64/virt/IORT.its_off | Bin 236 -> 172 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 2 -- > 3 files changed, 2 deletions(-) > > diff --git a/tests/data/acpi/aarch64/virt/APIC.its_off b/tests/data/acpi/aarch64/virt/APIC.its_off > index 37d82e970b1331cb5b259f0bd2d3654bacb2d623..6130cb7d07103b326feb4dcd7034f85808bebadf 100644 > GIT binary patch > delta 18 > ZcmdnNxP+0*F~HM#2?GNI3&%vRSpY2+1Zw~Q > > delta 39 > jcmZ3&xPy_)F~HM#2Ll5G%fX3UvqbnsfJ`vp;DE6JqX7kf > > diff --git a/tests/data/acpi/aarch64/virt/IORT.its_off b/tests/data/acpi/aarch64/virt/IORT.its_off > index 0fceb820d509e852ca0849baf568a8e93e426738..c10da4e61dd00e7eb062558a2735d49ca0b20620 100644 > GIT binary patch > delta 69 > zcmaFExQ3C-(?2L=4FdxM^Yn>aQj$zSmH`lh0E-I)3xowECx)7HGFdP%GXmL+6IZHp > Hz*GSMclZc% > > literal 236 > zcmebD4+?q1z`(#9?&R<65v<@85#X!<1dKp25F11@1F-=RgMkDCNC*yK9F_ zUBI%eoFED&4;F$FSwK1)h;xBB2Py`m{{M%tVD>TjFfcO#g+N#Zh@s|zoCF3AP#UU@ > R!2`+%Dg6Hr$N|zYvjDIZ5CH%H > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index a88198d5c2..dfb8523c8b 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,3 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/aarch64/virt/APIC.its_off", > -"tests/data/acpi/aarch64/virt/IORT.its_off",