From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dz0rx-0003yf-EB for qemu-devel@nongnu.org; Sat, 30 Jul 2005 19:35:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dz0rl-0003sR-FV for qemu-devel@nongnu.org; Sat, 30 Jul 2005 19:35:42 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dz0rk-0003lA-Ll for qemu-devel@nongnu.org; Sat, 30 Jul 2005 19:35:40 -0400 Received: from [66.45.225.74] (helo=alexandria32.alexsrv32.com) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1Dz0ma-0004i6-EJ for qemu-devel@nongnu.org; Sat, 30 Jul 2005 19:30:20 -0400 Message-ID: <42EC0A39.40404@steveperkins.net> Date: Sat, 30 Jul 2005 19:16:09 -0400 From: "Steve D. Perkins" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch Submission] QEMU with GCC/Win32 References: <42EBCA12.80603@steveperkins.net> <200507302013.22433.paul@codesourcery.com> <42EBD7E3.7090409@steveperkins.net> <200507310004.28470.paul@codesourcery.com> In-Reply-To: <200507310004.28470.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Paul Brook wrote: >"sledgehammer" and "nut" spring to mind :-) > >The attached patch is sufficient to get qemu working on win32 when compiled with gcc3.4. I've successfully booted a knoppix CD inside qemu on a windows host with this patch. > >The problem was that gcc is choosing inconvenient names for static local variables. These symbols are never supposed to be seen outside the compiler, so it's allowed to change these at random. The solution is to use explicitly specify the asm name for the variable. > >Paul > > Haha... thanks alot Paul! I now have a big bruise from slapping my palm against my forehead... seeing how much more simplified the changes could be after I went through all that hassle editing "dyngen.c"! Given that QEMU can support the current release of GCC on Windows by changing less than 40 lines of code in one file, can we please begin discussing the inclusion of these changes in the main codebase? Explicitly specifying this one variable name in a preprocessor directive doesn't look as if it would affect builds on other platforms, but it would be easy enough to test either way. Steve