From: Max Reitz <mreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
Date: Tue, 10 Sep 2019 12:57:52 +0200 [thread overview]
Message-ID: <42a0d9dc-fd96-637f-abb0-1879b7ff0ad3@redhat.com> (raw)
In-Reply-To: <6627619f-e0e2-f8fd-14b0-d675d5931ed0@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]
On 10.09.19 12:55, Thomas Huth wrote:
> On 10/09/2019 12.53, Max Reitz wrote:
>> On 06.09.19 13:35, Thomas Huth wrote:
>>> The check script is already printing out which iotest is currently
>>> running, so printing out the name of the check-block.sh shell script
>>> looks superfluous here.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> tests/Makefile.include | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>> (Not sure which tree you’d like this to go through...)
>
> I think either your block tree or trivial would be appropriate?
OK then, I’ve taken it. :-)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-09-10 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 11:35 [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script Thomas Huth
2019-09-09 16:40 ` John Snow
2019-09-10 10:53 ` Max Reitz
2019-09-10 10:55 ` Thomas Huth
2019-09-10 10:57 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a0d9dc-fd96-637f-abb0-1879b7ff0ad3@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).