From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Rebecca Cran <rebecca@nuviainc.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH-for-5.2 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com
Date: Mon, 16 Nov 2020 12:59:09 +0100 [thread overview]
Message-ID: <42a57502-3a85-0215-8af6-b76620b3a88a@redhat.com> (raw)
In-Reply-To: <20201113172519.31056-1-rebecca@nuviainc.com>
On 11/13/20 6:25 PM, Rebecca Cran wrote:
> Update containers.yml to use the $CI_REGISTRY variable as other files
> such as edk2.yml do.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> .gitlab-ci.d/containers.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> index 11d079ea5810..892ca8d838ce 100644
> --- a/.gitlab-ci.d/containers.yml
> +++ b/.gitlab-ci.d/containers.yml
> @@ -8,7 +8,7 @@
> - export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest"
> - apk add python3
> - docker info
> - - docker login registry.gitlab.com -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
> + - docker login $CI_REGISTRY -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
> script:
> - echo "TAG:$TAG"
> - echo "COMMON_TAG:$COMMON_TAG"
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2020-11-16 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 17:25 [PATCH 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com Rebecca Cran
2020-11-16 11:59 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a57502-3a85-0215-8af6-b76620b3a88a@redhat.com \
--to=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rebecca@nuviainc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).