From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Ben Pye" <ben@curlybracket.co.uk>,
"Stefan Weil" <sw@weilnetz.de>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
"Jeff Cody" <jcody@redhat.com>, "Cédric Le Goater" <clg@kaod.org>,
"Thomas Huth" <thuth@redhat.com>,
"Liu Yuan" <namei.unix@gmail.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Max Reitz" <mreitz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
1803872@bugs.launchpad.net, "Juan Quintela" <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation
Date: Tue, 18 Dec 2018 17:38:17 +0100 [thread overview]
Message-ID: <42bc04b0-71b7-c9aa-554e-a337351b1e7e@redhat.com> (raw)
In-Reply-To: <20181218095334-mutt-send-email-mst@kernel.org>
On 18/12/18 15:54, Michael S. Tsirkin wrote:
> On Tue, Dec 18, 2018 at 03:45:08PM +0100, Paolo Bonzini wrote:
>> On 18/12/18 15:31, Michael S. Tsirkin wrote:
>>> Do you happen to know why does it build fine with
>>> Gcc 8.2.1?
>>>
>>> Reading the GCC manual it seems that
>>> there is a "nostring" attribute that means
>>> "might not be 0 terminated".
>>> I think we should switch to that which fixes the warning
>>> but also warns if someone tries to misuse these
>>> as C-strings.
>>>
>>> Seems to be a better option, does it not?
>>>
>>>
>>
>> Using strpadcpy is clever and self-documenting, though. We have it
>> already, so why not use it.
>>
>> Paolo
>
> The advantage of nonstring is that it will catch attempts to
> use these fields with functions that expect a 0 terminated string.
>
> strpadcpy will instead just silence the warning.
Ah, I see. We could also do both, that's a matter of taste.
Paolo
next prev parent reply other threads:[~2018-12-18 16:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 11:03 [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation Philippe Mathieu-Daudé
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0') Philippe Mathieu-Daudé
2018-12-18 11:09 ` Philippe Mathieu-Daudé
2018-12-18 14:29 ` Igor Mammedov
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 2/3] block/sheepdog: " Philippe Mathieu-Daudé
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 3/3] migration: " Philippe Mathieu-Daudé
2018-12-18 14:31 ` [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation Michael S. Tsirkin
2018-12-18 14:36 ` Daniel P. Berrangé
2018-12-18 14:39 ` Michael S. Tsirkin
2018-12-18 14:45 ` Paolo Bonzini
2018-12-18 14:54 ` Michael S. Tsirkin
2018-12-18 16:38 ` Paolo Bonzini [this message]
2018-12-18 17:03 ` Michael S. Tsirkin
2018-12-18 17:38 ` Daniel P. Berrangé
2018-12-18 16:55 ` Philippe Mathieu-Daudé
2018-12-18 17:04 ` Michael S. Tsirkin
2018-12-18 17:12 ` Paolo Bonzini
2018-12-18 17:17 ` Michael S. Tsirkin
2018-12-18 17:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bc04b0-71b7-c9aa-554e-a337351b1e7e@redhat.com \
--to=pbonzini@redhat.com \
--cc=1803872@bugs.launchpad.net \
--cc=armbru@redhat.com \
--cc=ben@curlybracket.co.uk \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=hsp.cat7@gmail.com \
--cc=imammedo@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=namei.unix@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).