From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D877C433E3 for ; Fri, 17 Jul 2020 13:26:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD9CF2067D for ; Fri, 17 Jul 2020 13:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cC4DH0fG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD9CF2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwQNh-0001IJ-7D for qemu-devel@archiver.kernel.org; Fri, 17 Jul 2020 09:26:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwQN5-0000qw-4j for qemu-devel@nongnu.org; Fri, 17 Jul 2020 09:25:51 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jwQN3-0005RA-7E for qemu-devel@nongnu.org; Fri, 17 Jul 2020 09:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594992347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b1Fih/UlbYodYH4cdyXYDwj2s8duM+GS56VRx2X0Lec=; b=cC4DH0fGzRpv1SpbsgQ3kL8OZykO9SQpucGMeCnQuLV99WYfivsAeO3Gs2x/e0JBx87eqr mLHHaf65OPL3rL0HyqdKuHKTqcZM+kkzXgUV50E8LNKjaV2tQfA7JnkXBuQqGZCKrySLRZ +fNemj3ED7ofxu+gOhXqurjZowG9lNc= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-DgbI5EpsNdmMuSCbsTD68w-1; Fri, 17 Jul 2020 09:25:46 -0400 X-MC-Unique: DgbI5EpsNdmMuSCbsTD68w-1 Received: by mail-ej1-f72.google.com with SMTP id q11so5722122eja.3 for ; Fri, 17 Jul 2020 06:25:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=b1Fih/UlbYodYH4cdyXYDwj2s8duM+GS56VRx2X0Lec=; b=Ale4lHix2Yj+oubMRXGo7R61IZZ1iRn9cGK8s4RMrgcTJLeqVX2jGD2lyLWbYRm644 2Uk8OaVJVbrqOkeE/rTjFSPIN70Vx51jIANDLCIufZLJGz0cl/osRdez/XdcdDJe+kZi wiovbLksIaRI3ecrAZsrJpFNpLcQzJZXgp2z0Ded0m7TeIHZLMxqm8BG/0VpoCr6CshB mz8P5g6loVqY/xzPIkYdw865Mw2qpi5mgj6od8V1VW9Co3HW3pGAlMhQWsg1nhffrznK bg0xhorVD2UB8ZTQ8V0ZC6EQSGLqyXXBhJGNkGHqZGm1jkUUVIiIhI3+F/KQS/LZnyDh 1IAw== X-Gm-Message-State: AOAM5303uUUIlUPSOCjtkcAr9WCO3lrBwflrU/vmKt2spSeNrjujwSwc rwHC/YBmwiRkUD/8S05fcPOJit15t4Bu4dvVw8POry8UMgvjs3ufoo1o6BDIfF/BePIf9IeN7cn DzxFX5sbPcNJE14Q= X-Received: by 2002:a17:906:280c:: with SMTP id r12mr6077193ejc.105.1594992345016; Fri, 17 Jul 2020 06:25:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmZ7QQjb4Rjda1kjq0HKP6IIXqsbQ6D3HTYNOUTrCmdxUa0vsrGXgAGbkJGL9gI3fui0LZ4w== X-Received: by 2002:a17:906:280c:: with SMTP id r12mr6077173ejc.105.1594992344718; Fri, 17 Jul 2020 06:25:44 -0700 (PDT) Received: from [192.168.1.37] (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id w18sm8166943edv.11.2020.07.17.06.25.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 06:25:44 -0700 (PDT) Subject: Re: tests/vm infrastructure fails to notice that QEMU dying is a failure From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Peter Maydell , QEMU Developers References: <890eb42e-cd77-2a63-c441-61637ac5094f@redhat.com> Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <42c71a79-4911-dc47-d983-783d98e819c5@redhat.com> Date: Fri, 17 Jul 2020 15:25:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <890eb42e-cd77-2a63-c441-61637ac5094f@redhat.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/17 05:27:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/17/20 3:22 PM, Philippe Mathieu-Daudé wrote: > Cc'ing John & Cleber. > > On 7/17/20 3:08 PM, Peter Maydell wrote: >> If you run vm-build-openbsd, our makefile/scripting infrastructure >> seems to fail to notice that death of the QEMU process that's >> running the VM should be a failure, and ends up allowing make >> to return a success condition. >> >> I have a script which runs a VM build which basically does: >> >> #!/bin/sh -e >> make -C "build" "vm-build-openbsd" J=8 V=1 >> echo "OK DONE openbsd" >> >> It just gave me this output (tail end of logfile). We're executing tests, >> and then the qemu-system-x86_64 that's running the OpenBSD VM gets >> a signal 9 (sigkill), for unclear reasons (oom killer??). The python >> scripting gets an exception, but doesn't exit with a failure status to >> make, which then thinks all is fine, exits success itself and allows >> the set -e script to proceed to print the "OK DONE" line... >> >> >> PASS 30 qos-test /arm/imx25-pdk/imx.i2c/i2c-bus/pca9552/pca9552-tests/tx-rx >> PASS 31 qos-test /arm/imx25-pdk/imx.i2c/i2c-bus/pca9552/pca9552-tests/rx-autoinc >> PASS 32 qos-test /arm/imx25-pdk/imx.i2c/i2c-bus/ds1338/ds1338-tests/tx-rx >> DEBUG:QMP.qemu-26462:>>> {'execute': 'quit'} >> DEBUG:QMP.qemu-26462:<<< {'timestamp': {'seconds': 1594984057, >> 'microseconds': 485197}, 'event': 'NIC_RX_FILTER_CHANGED', 'data': >> {'path': '/machine/peripheral-anon/device[0]/virtio-backend'}} >> DEBUG:QMP.qemu-26462:<<< {'timestamp': {'seconds': 1594985855, >> 'microseconds': 169552}, 'event': 'RTC_CHANGE', 'data': {'offset': 0}} >> DEBUG:QMP.qemu-26462:<<< {'timestamp': {'seconds': 1594987655, >> 'microseconds': 169187}, 'event': 'RTC_CHANGE', 'data': {'offset': 0}} >> DEBUG:QMP.qemu-26462:<<< {'timestamp': {'seconds': 1594989456, >> 'microseconds': 88866}, 'event': 'RTC_CHANGE', 'data': {'offset': 0}} >> DEBUG:QMP.qemu-26462:<<< {'return': {}} >> WARNING:qemu.machine:qemu received signal 9; command: >> "qemu-system-x86_64 -display none -vga none -chardev >> socket,id=mon,path=/var/tmp/qemu-26462-monitor.sock -mon >> chardev=mon,mode=control -machine pc -chardev >> socket,id=console,path=/var/tmp/qemu-26462-console.sock,server,nowait >> -serial chardev:console -nodefaults -m 4G -cpu max -netdev >> user,id=vnet,hostfwd=:127.0.0.1:0-:22 -device >> virtio-net-pci,netdev=vnet -vnc 127.0.0.1:0,to=20 -smp 8 -enable-kvm >> -drive file=/home/peter.maydell/.cache/qemu-vm/images/openbsd.img,snapshot=on,if=none,id=drive0,cache=writeback >> -device virtio-blk,drive=drive0,bootindex=0 -drive >> file=/home/peter.maydell/qemu-openbsd/build/vm-test-yzwn6xdc.tmp/data-993a1.tar,if=none,id=data-993a1,cache=writeback,format=raw >> -device virtio-blk,drive=data-993a1,serial=data-993a1,bootindex=1" >> Error in atexit._run_exitfuncs: >> Traceback (most recent call last): >> File "/home/peter.maydell/qemu-openbsd/tests/vm/../../python/qemu/machine.py", >> line 436, in _do_shutdown >> self._soft_shutdown(has_quit, timeout) >> File "/home/peter.maydell/qemu-openbsd/tests/vm/../../python/qemu/machine.py", >> line 419, in _soft_shutdown >> self._popen.wait(timeout=timeout) >> File "/usr/lib/python3.6/subprocess.py", line 1469, in wait >> raise TimeoutExpired(self.args, timeout) >> subprocess.TimeoutExpired: Command '['qemu-system-x86_64', '-display', >> 'none', '-vga', 'none', '-chardev', >> 'socket,id=mon,path=/var/tmp/qemu-26462-monitor.sock', '-mon', >> 'chardev=mon,mode=control', '-machine', 'pc', '-chardev', >> 'socket,id=console,path=/var/tmp/qemu-26462-console.sock,server,nowait', >> '-serial', 'chardev:console', '-nodefaults', '-m', '4G', '-cpu', >> 'max', '-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22', '-device', >> 'virtio-net-pci,netdev=vnet', '-vnc', '127.0.0.1:0,to=20', '-smp', >> '8', '-enable-kvm', '-drive', >> 'file=/home/peter.maydell/.cache/qemu-vm/images/openbsd.img,snapshot=on,if=none,id=drive0,cache=writeback', >> '-device', 'virtio-blk,drive=drive0,bootindex=0', '-drive', >> 'file=/home/peter.maydell/qemu-openbsd/build/vm-test-yzwn6xdc.tmp/data-993a1.tar,if=none,id=data-993a1,cache=writeback,format=raw', >> '-device', 'virtio-blk,drive=data-993a1,serial=data-993a1,bootindex=1']' >> timed out after 3 seconds >> >> The above exception was the direct cause of the following exception: >> >> Traceback (most recent call last): >> File "/home/peter.maydell/qemu-openbsd/tests/vm/../../python/qemu/machine.py", >> line 466, in shutdown >> self._do_shutdown(has_quit, timeout=timeout) >> File "/home/peter.maydell/qemu-openbsd/tests/vm/../../python/qemu/machine.py", >> line 440, in _do_shutdown >> from exc >> qemu.machine.AbnormalShutdown: Could not perform graceful shutdown >> make: Leaving directory '/home/peter.maydell/qemu-openbsd/build' >> OK DONE openbsd John it seems due to the addition of the 'finally' clause in 193bf1c061 ("python/machine.py: split shutdown into hard and soft flavors"). >> >> thanks >> -- PMM >> >