From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD4CC433E0 for ; Tue, 2 Jun 2020 11:40:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CCFC206A2 for ; Tue, 2 Jun 2020 11:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FZFUEfox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CCFC206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg5HT-0000gQ-GL for qemu-devel@archiver.kernel.org; Tue, 02 Jun 2020 07:40:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg5Ga-00089T-Uc for qemu-devel@nongnu.org; Tue, 02 Jun 2020 07:39:36 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:28278 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jg5GZ-0005SE-J8 for qemu-devel@nongnu.org; Tue, 02 Jun 2020 07:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591097974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYLpVsLp/f/yA4wx+yqX/lgqq4VfZA4A9vuREHBIsuQ=; b=FZFUEfox403Abh6ewu9i5rSKlrJmjNkPe0kPYkyw72/37P0BJroFHQb9ODXhH57WP3rvVA XLwyjvuVtt0eSDXb6sagxaEaHc/nS29ShAPdzyxbZEez2pNbPAegpkKNDvhaKT9lWCXxug 7UTvMB5kAScKJY18unTsBvC5sCuTAn8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-OM-ObyoQO5iZE24mjT4LtQ-1; Tue, 02 Jun 2020 07:39:32 -0400 X-MC-Unique: OM-ObyoQO5iZE24mjT4LtQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F1B280058E; Tue, 2 Jun 2020 11:39:31 +0000 (UTC) Received: from [10.36.113.56] (ovpn-113-56.ams2.redhat.com [10.36.113.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D0BF579A3; Tue, 2 Jun 2020 11:39:24 +0000 (UTC) Subject: Re: [PATCH] checkpatch: reversed logic with acpi test checks To: "Michael S. Tsirkin" , qemu-devel@nongnu.org References: <20200602053614.54745-1-mst@redhat.com> From: Auger Eric Message-ID: <42dc9203-e7bd-1f69-dad8-a4311a5a6b64@redhat.com> Date: Tue, 2 Jun 2020 13:39:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200602053614.54745-1-mst@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eric.auger@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/01 23:49:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , Stefan Hajnoczi , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin Fixes issues reported in "[RFC 0/6] TPM-TIS bios-tables-test" cover letter Reviewed-by: Eric Auger Tested-by: Eric Auger Thanks Eric > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 0ba213e9f2..55aa45dc16 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1267,7 +1267,7 @@ sub checkfilename { > # files and when changing tests. > if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) { > $$acpi_testexpected = $name; > - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) { > + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) { > $$acpi_nontestexpected = $name; > } > if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) { >