From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH] gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit
Date: Tue, 26 Jan 2021 13:42:13 +0100 [thread overview]
Message-ID: <42e698a8-f764-6e38-eba6-55137fc9802b@redhat.com> (raw)
In-Reply-To: <bd0ff3d1-56a4-ba1d-8129-521937b092b2@redhat.com>
On 26/01/2021 13.08, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
> On 1/21/21 6:44 PM, Thomas Huth wrote:
>> Since the meson build system rework, the configure script prefers the
>> git submodules over the system libraries. So we are testing compilation
>> with capstone, fdt and libslirp as a submodule all over the place,
>> burning CPU cycles by recompiling these third party modules and wasting
>> some network bandwidth in the CI by cloning the submodules each time.
>> Let's stop doing that in at least a couple of jobs and use the system
>> libraries instead.
>>
>> While we're at it, also install meson in the Fedora container, since
>> it is new enough already, so we do not need to check out the meson
>> submodule here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> .gitlab-ci.yml | 6 +++++-
>> tests/docker/dockerfiles/centos8.docker | 1 +
>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
>> tests/docker/dockerfiles/fedora.docker | 3 +++
>> tests/docker/dockerfiles/ubuntu2004.docker | 1 +
>> 5 files changed, 11 insertions(+), 1 deletion(-)
>
> So now which are the jobs left building from git submodule clone?
All the jobs which don't have a depending test stage jobs should still use
the submodules, e.g. build-oss-fuzz, build-tci, etc.
Also the centos7-based jobs still use all submodules, e.g.
build-crypto-old-nettle etc.
Thomas
prev parent reply other threads:[~2021-01-26 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:44 [PATCH] gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit Thomas Huth
2021-01-26 12:08 ` Philippe Mathieu-Daudé
2021-01-26 12:42 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42e698a8-f764-6e38-eba6-55137fc9802b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).