From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 5/6] tests/libqtest: Move global_test wrapper function into a separate header
Date: Wed, 4 Sep 2019 14:09:54 -0500 [thread overview]
Message-ID: <42f1e032-36de-2692-b425-9bb14303c9ea@redhat.com> (raw)
In-Reply-To: <20190904185130.GE26826@stefanha-x1.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1371 bytes --]
On 9/4/19 1:51 PM, Stefan Hajnoczi wrote:
> On Wed, Sep 04, 2019 at 03:00:46PM +0200, Thomas Huth wrote:
>> diff --git a/tests/libqtest-single.h b/tests/libqtest-single.h
>> new file mode 100644
>> index 0000000000..49259558a5
>> --- /dev/null
>> +++ b/tests/libqtest-single.h
>> +static inline QTestState *qtest_start(const char *args)
>> +{
>> + global_qtest = qtest_init(args);
>
> Where are global_qtest and qtest_init() declared? I would expect
> compilation to fail if a .c file included just "libqtest-single.h".
In patch 5, "libqtest.h" declares global_qtest, then includes
"libqtest-single.h"; no file includes it standalone. Then in patch 6,
the roles are swapped; "libqtest-single.h" declares global_qtest and
includes "libqtest.h". But yes, the commit message could do better in
explaining this.
> Missing #include?
>
> If this header is not supposed to be included by .c files, please
> include at least a comment or use a magic #define + #ifdef to prevent
> inclusion.
The condition is transient for one patch; but calling it out better in
the commit message and/or as a comment (especially since the #include
"libqtest-single.h" is not in the normal #includes up front) would help.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-04 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 13:00 [Qemu-devel] [PATCH v2 0/6] Make the core libqtest library independe from global_qtest Thomas Huth
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 1/6] tests/migration: Do not use functions anymore that rely on global_qtest Thomas Huth
2019-09-04 18:52 ` Stefan Hajnoczi
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest Thomas Huth
2019-09-04 18:52 ` Stefan Hajnoczi
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code Thomas Huth
2019-09-04 14:17 ` Eric Blake
2019-09-04 18:52 ` Stefan Hajnoczi
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 4/6] tests: Remove unnecessary global_qtest references Thomas Huth
2019-09-04 14:18 ` Eric Blake
2019-09-04 18:52 ` Stefan Hajnoczi
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 5/6] tests/libqtest: Move global_test wrapper function into a separate header Thomas Huth
2019-09-04 14:23 ` Eric Blake
2019-09-04 18:51 ` Stefan Hajnoczi
2019-09-04 19:09 ` Eric Blake [this message]
2019-09-05 7:06 ` Thomas Huth
2019-09-04 13:00 ` [Qemu-devel] [PATCH v2 6/6] tests/libqtest: Use libqtest-single.h in tests that require global_qtest Thomas Huth
2019-09-04 14:25 ` Eric Blake
2019-09-04 18:52 ` Stefan Hajnoczi
2019-09-04 18:52 ` [Qemu-devel] [PATCH v2 0/6] Make the core libqtest library independe from global_qtest Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f1e032-36de-2692-b425-9bb14303c9ea@redhat.com \
--to=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).