From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCT8p-0000x1-Vp for qemu-devel@nongnu.org; Wed, 08 Nov 2017 11:23:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCT8p-0002Aj-AA for qemu-devel@nongnu.org; Wed, 08 Nov 2017 11:23:51 -0500 Sender: Richard Henderson References: <20171108153245.20740-1-alex.bennee@linaro.org> <20171108153245.20740-2-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <42f49754-f402-694e-fbe4-acad66761863@twiddle.net> Date: Wed, 8 Nov 2017 17:23:37 +0100 MIME-Version: 1.0 In-Reply-To: <20171108153245.20740-2-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] accel/tcg/translate-all: expand cpu_restore_state addr check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , Peter Crosthwaite On 11/08/2017 04:32 PM, Alex Bennée wrote: > We are still seeing signals during translation time when we walk over > a page protection boundary. This expands the check to ensure the host > PC is inside the code generation buffer. The original suggestion was > to check versus tcg_ctx.code_gen_ptr but as we now segment the > translation buffer we have to settle for just a general check for > being inside. > > I've also fixed up the declaration to make it clear it can deal with > invalid addresses. A later patch will fix up the call sites. > > Signed-off-by: Alex Bennée > Reported-by: Peter Maydell > Suggested-by: Paolo Bonzini > Cc: Richard Henderson Reviewed-by: Richard Henderson r~