From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B6CAC64ED6 for ; Wed, 1 Mar 2023 17:53:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXQdB-0005Oi-9j; Wed, 01 Mar 2023 12:52:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXQd8-0005ON-9H for qemu-devel@nongnu.org; Wed, 01 Mar 2023 12:52:42 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXQd6-0000fD-Kw for qemu-devel@nongnu.org; Wed, 01 Mar 2023 12:52:41 -0500 Received: by mail-wr1-x433.google.com with SMTP id bx12so10962503wrb.11 for ; Wed, 01 Mar 2023 09:52:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677693158; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r5OW/MpZn6t0tHKu1yQh/I+98WeAdFzFmQo9cSRwnRs=; b=DJyW2oziP9YaqfFqy/dSOKFtfwmdvyLCUKlwOqNb7UN4k2/CFFjnn4gbugt/qb0xRi ZOfb4pi62RLlMUVdlGt8lBpn92RmqfUs/ChKfT58oaeQoroxdUYYfwqjzTXCspz1SH8L Nb/GnMZ4Civl2Ydu3jZMq5hIHt1xZ6qhM0vJrvMEiX8bpb5vFER8RySmpy8JjzwThuEU LmwOLsvFoqC1mSzweJvUBICN+Vtwzo75DSPIi+AinYeL6038H0X76yDgnpePSYlGoJR4 CWEGJvr1Mrs5AeTBmuTYxYPDvgcKW/JBpsH3pk1P3MSywezqiGtv2Fdktwex/UDu5KLc /PZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677693158; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r5OW/MpZn6t0tHKu1yQh/I+98WeAdFzFmQo9cSRwnRs=; b=7B4qZJRHGIqMAQRfJmYSY9odW/2+Qnmq2seGJiDsq+pJGNKpMdrgkkOWklHRX9nJZF oesuIKZrngB1fwhEwpgsVQ68mY+rfXlu7fJYDVfho3JBraOFwAoO5yb2bdCTPqoj1bPd 6TQNsbKf0oWEwGKMbfxQIR20RKCRyB7NlEP8E7o/DtglMqCVy0C9GsnZa5oDg4EGSvnV sIqiCq6UqVpbP+NJsKdvvSQkVp4rpFJJBHDg3K0qr0SXnu9GqQ3/NRbVMQhS2LQJpZLF UOcxTCjzItWe1VkolAYYOEoS0UW1E0dp9A4ykNTyyy8uXTHS2mq4qem3VxNLINSFgxil o5iQ== X-Gm-Message-State: AO0yUKXbL/lOAM3TzB4Ztr0yHHme861DnqCTHcQjNzUJg4IN2i+jURWj 8/p/idCVU3WtSeUeHw1F1zoFaA== X-Google-Smtp-Source: AK7set/xhtuPoMFsUYgwTB2lRUxQ5CiXKtcEPkVuKxR12gNwCeLBhTfT8/nmma3An2wAUMi8m2512A== X-Received: by 2002:a5d:6388:0:b0:2c5:4cd0:4b86 with SMTP id p8-20020a5d6388000000b002c54cd04b86mr5293321wru.68.1677693158244; Wed, 01 Mar 2023 09:52:38 -0800 (PST) Received: from [192.168.45.175] (41.red-88-29-167.dynamicip.rima-tde.net. [88.29.167.41]) by smtp.gmail.com with ESMTPSA id n5-20020a5d51c5000000b002c70d97af78sm13463701wrv.85.2023.03.01.09.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Mar 2023 09:52:37 -0800 (PST) Message-ID: <4306d877-e667-4bf9-276c-a68bf4e9717e@linaro.org> Date: Wed, 1 Mar 2023 18:52:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 09/11] aspeed: Introduce a spi_boot region under the SoC Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Peter Maydell , Joel Stanley , Andrew Jeffery References: <20230301165619.2171090-1-clg@kaod.org> <20230301165619.2171090-10-clg@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230301165619.2171090-10-clg@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/3/23 17:56, Cédric Le Goater wrote: > The default boot address of the Aspeed SoCs is 0x0. For this reason, > the FMC flash device contents are remapped by HW on the first 256MB of > the address space. In QEMU, this is currently done in the machine init > with the setup of a region alias. > > Move this code to the SoC and introduce an extra container to prepare > ground for the boot ROM region which will overlap the FMC flash > remapping. > > Signed-off-by: Cédric Le Goater > --- > include/hw/arm/aspeed_soc.h | 5 +++++ > hw/arm/aspeed.c | 13 +------------ > hw/arm/aspeed_ast2600.c | 13 +++++++++++++ > hw/arm/aspeed_soc.c | 14 ++++++++++++++ Why aspeed2600 duplicates a lot of aspeed_soc_init() / aspeed_soc_realize() while inheriting from TYPE_ASPEED_SOC? Is that on purpose or because not using device_class_set_parent_realize? Reviewed-by: Philippe Mathieu-Daudé > hw/arm/fby35.c | 8 +------- > 5 files changed, 34 insertions(+), 19 deletions(-)