From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] cpus: Drop declaration of cpu_remove()
Date: Wed, 14 Oct 2020 15:48:32 +0200 [thread overview]
Message-ID: <431287f0-94a9-8c81-443a-b3d80ca33a32@redhat.com> (raw)
In-Reply-To: <160268285707.1107461.15035929822602623985.stgit@bahia.lan>
On 10/14/20 3:40 PM, Greg Kurz wrote:
> cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
> but its prototype wasn't removed. We could possibly keep the shorter
> cpu_remove() naming but it seems better to highligth that this blocks
> until the CPU thread is joined.
>
> Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
> Cc: pbonzini@redhat.com
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> include/hw/core/cpu.h | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-14 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:40 [PATCH] cpus: Drop declaration of cpu_remove() Greg Kurz
2020-10-14 13:48 ` Philippe Mathieu-Daudé [this message]
2020-10-26 19:20 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431287f0-94a9-8c81-443a-b3d80ca33a32@redhat.com \
--to=philmd@redhat.com \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).