* [PATCH] cpus: Drop declaration of cpu_remove()
@ 2020-10-14 13:40 Greg Kurz
2020-10-14 13:48 ` Philippe Mathieu-Daudé
2020-10-26 19:20 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Greg Kurz @ 2020-10-14 13:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
but its prototype wasn't removed. We could possibly keep the shorter
cpu_remove() naming but it seems better to highligth that this blocks
until the CPU thread is joined.
Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
Cc: pbonzini@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
---
include/hw/core/cpu.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 4879f2502659..ace443e88297 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -924,14 +924,6 @@ void cpu_exit(CPUState *cpu);
void cpu_resume(CPUState *cpu);
/**
- * cpu_remove:
- * @cpu: The CPU to remove.
- *
- * Requests the CPU to be removed.
- */
-void cpu_remove(CPUState *cpu);
-
- /**
* cpu_remove_sync:
* @cpu: The CPU to remove.
*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpus: Drop declaration of cpu_remove()
2020-10-14 13:40 [PATCH] cpus: Drop declaration of cpu_remove() Greg Kurz
@ 2020-10-14 13:48 ` Philippe Mathieu-Daudé
2020-10-26 19:20 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-14 13:48 UTC (permalink / raw)
To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
On 10/14/20 3:40 PM, Greg Kurz wrote:
> cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
> but its prototype wasn't removed. We could possibly keep the shorter
> cpu_remove() naming but it seems better to highligth that this blocks
> until the CPU thread is joined.
>
> Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
> Cc: pbonzini@redhat.com
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> include/hw/core/cpu.h | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpus: Drop declaration of cpu_remove()
2020-10-14 13:40 [PATCH] cpus: Drop declaration of cpu_remove() Greg Kurz
2020-10-14 13:48 ` Philippe Mathieu-Daudé
@ 2020-10-26 19:20 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-10-26 19:20 UTC (permalink / raw)
To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Le 14/10/2020 à 15:40, Greg Kurz a écrit :
> cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
> but its prototype wasn't removed. We could possibly keep the shorter
> cpu_remove() naming but it seems better to highligth that this blocks
> until the CPU thread is joined.
>
> Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
> Cc: pbonzini@redhat.com
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> include/hw/core/cpu.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
> index 4879f2502659..ace443e88297 100644
> --- a/include/hw/core/cpu.h
> +++ b/include/hw/core/cpu.h
> @@ -924,14 +924,6 @@ void cpu_exit(CPUState *cpu);
> void cpu_resume(CPUState *cpu);
>
> /**
> - * cpu_remove:
> - * @cpu: The CPU to remove.
> - *
> - * Requests the CPU to be removed.
> - */
> -void cpu_remove(CPUState *cpu);
> -
> - /**
> * cpu_remove_sync:
> * @cpu: The CPU to remove.
> *
>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-14 13:40 [PATCH] cpus: Drop declaration of cpu_remove() Greg Kurz
2020-10-14 13:48 ` Philippe Mathieu-Daudé
2020-10-26 19:20 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).