From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gregory Kurz" <gregory.kurz@free.fr>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Stefano Brivio" <sbrivio@redhat.com>
Subject: Re: [PATCH v8 06/14] net: stream: Don't ignore EINVAL on netdev socket connection
Date: Fri, 23 Sep 2022 16:58:21 +0200 [thread overview]
Message-ID: <4326b13b-807b-a5c3-cd27-6913ba89bdd1@redhat.com> (raw)
In-Reply-To: <YyFhADVRPSB4ZT4p@yekko>
On 9/14/22 07:05, David Gibson wrote:
> On Tue, Sep 13, 2022 at 08:39:52AM +0200, Laurent Vivier wrote:
>> From: Stefano Brivio <sbrivio@redhat.com>
>>
>> Other errors are treated as failure by net_stream_client_init(),
>> but if connect() returns EINVAL, we'll fail silently. Remove the
>> related exception.
>
> Is this also a bug in net_socket_connect_init()? Is there an
> equivalent bug in dgram.c?
Yes, the bug has been found by Stefano in socket.c, I'm adding his patch to the series.
There is no equivalent bug in dgram.c
Thanks,
Laurent
next prev parent reply other threads:[~2022-09-23 15:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 6:39 [PATCH v8 00/14] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 01/14] net: introduce convert_host_port() Laurent Vivier
2022-09-14 2:26 ` David Gibson
2022-09-13 6:39 ` [PATCH v8 02/14] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-09-14 2:28 ` David Gibson
2022-09-13 6:39 ` [PATCH v8 03/14] net: simplify net_client_parse() error management Laurent Vivier
2022-09-14 2:29 ` David Gibson
2022-09-13 6:39 ` [PATCH v8 04/14] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 05/14] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-09-14 5:03 ` David Gibson
2022-09-13 6:39 ` [PATCH v8 06/14] net: stream: Don't ignore EINVAL on netdev socket connection Laurent Vivier
2022-09-14 5:05 ` David Gibson
2022-09-23 14:58 ` Laurent Vivier [this message]
2022-09-13 6:39 ` [PATCH v8 07/14] net: stream: add unix socket Laurent Vivier
2022-09-14 5:16 ` David Gibson
2022-09-26 12:15 ` Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 08/14] net: dgram: make dgram_dst generic Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 09/14] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 10/14] net: dgram: add unix socket Laurent Vivier
2022-09-13 6:39 ` [PATCH v8 11/14] qemu-sockets: move and rename SocketAddress_to_str() Laurent Vivier
2022-09-14 5:23 ` David Gibson
2022-09-14 19:08 ` Dr. David Alan Gilbert
2022-09-13 6:39 ` [PATCH v8 12/14] qemu-sockets: update socket_uri() and socket_parse() to be consistent Laurent Vivier
2022-09-14 19:06 ` Dr. David Alan Gilbert
2022-09-21 15:01 ` Markus Armbruster
2022-09-13 6:39 ` [PATCH v8 13/14] net: stream: move to QIO Laurent Vivier
2022-09-21 14:58 ` Markus Armbruster
2022-09-22 9:13 ` Laurent Vivier
2022-09-22 9:40 ` Markus Armbruster
2022-09-13 6:40 ` [PATCH v8 14/14] tests/qtest: netdev: test stream and dgram backends Laurent Vivier
2022-09-13 10:24 ` [PATCH v8 00/14] qapi: net: add unix socket type support to netdev backend Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4326b13b-807b-a5c3-cd27-6913ba89bdd1@redhat.com \
--to=lvivier@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=gregory.kurz@free.fr \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sbrivio@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).