From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Li Qiang <liq3ea@163.com>, vsementsov@virtuozzo.com, kwolf@redhat.com
Cc: liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
Date: Sun, 10 Mar 2019 15:34:08 +0100 [thread overview]
Message-ID: <43275bae-952c-c044-0525-5e6592dbe58d@redhat.com> (raw)
In-Reply-To: <20190310113408.59912-1-liq3ea@163.com>
On 3/10/19 12:34 PM, Li Qiang wrote:
> Fixes: 2dbfadf
^ Please keep tags together (with Signed-off-by, ...)
> Spotted by ASAN when 'make check'.
I'm not native English speaker but I'd say:
Spotted by ASAN [with] 'make check'.
or
Spotted by ASAN [while running] 'make check'.
Here goes:
"Fixes: 2dbfadf"
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> tests/test-bdrv-graph-mod.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> index 458dfa6661..8bf0fe735d 100644
> --- a/tests/test-bdrv-graph-mod.c
> +++ b/tests/test-bdrv-graph-mod.c
> @@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
>
> bdrv_unref(bs);
> blk_unref(root);
> + error_free(local_err);
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> }
>
> /*
>
next prev parent reply other threads:[~2019-03-10 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 11:34 [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak Li Qiang
2019-03-10 14:34 ` Philippe Mathieu-Daudé [this message]
2019-03-12 0:31 ` Li Qiang
2019-03-11 7:55 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43275bae-952c-c044-0525-5e6592dbe58d@redhat.com \
--to=philmd@redhat.com \
--cc=kwolf@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).