* [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
@ 2019-03-10 11:34 Li Qiang
2019-03-10 14:34 ` Philippe Mathieu-Daudé
2019-03-11 7:55 ` Vladimir Sementsov-Ogievskiy
0 siblings, 2 replies; 4+ messages in thread
From: Li Qiang @ 2019-03-10 11:34 UTC (permalink / raw)
To: vsementsov, kwolf; +Cc: qemu-devel, liq3ea, Li Qiang
Fixes: 2dbfadf
Spotted by ASAN when 'make check'.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
tests/test-bdrv-graph-mod.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
index 458dfa6661..8bf0fe735d 100644
--- a/tests/test-bdrv-graph-mod.c
+++ b/tests/test-bdrv-graph-mod.c
@@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
bdrv_unref(bs);
blk_unref(root);
+ error_free(local_err);
}
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
2019-03-10 11:34 [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak Li Qiang
@ 2019-03-10 14:34 ` Philippe Mathieu-Daudé
2019-03-12 0:31 ` Li Qiang
2019-03-11 7:55 ` Vladimir Sementsov-Ogievskiy
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-10 14:34 UTC (permalink / raw)
To: Li Qiang, vsementsov, kwolf; +Cc: liq3ea, qemu-devel
On 3/10/19 12:34 PM, Li Qiang wrote:
> Fixes: 2dbfadf
^ Please keep tags together (with Signed-off-by, ...)
> Spotted by ASAN when 'make check'.
I'm not native English speaker but I'd say:
Spotted by ASAN [with] 'make check'.
or
Spotted by ASAN [while running] 'make check'.
Here goes:
"Fixes: 2dbfadf"
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> tests/test-bdrv-graph-mod.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> index 458dfa6661..8bf0fe735d 100644
> --- a/tests/test-bdrv-graph-mod.c
> +++ b/tests/test-bdrv-graph-mod.c
> @@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
>
> bdrv_unref(bs);
> blk_unref(root);
> + error_free(local_err);
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> }
>
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
2019-03-10 14:34 ` Philippe Mathieu-Daudé
@ 2019-03-12 0:31 ` Li Qiang
0 siblings, 0 replies; 4+ messages in thread
From: Li Qiang @ 2019-03-12 0:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Li Qiang, vsementsov, kwolf, Qemu Developers
Philippe Mathieu-Daudé <philmd@redhat.com> 于2019年3月10日周日 下午10:34写道：
> On 3/10/19 12:34 PM, Li Qiang wrote:
> > Fixes: 2dbfadf
>
> ^ Please keep tags together (with Signed-off-by, ...)
>
> > Spotted by ASAN when 'make check'.
>
> I'm not native English speaker but I'd say:
>
>
Thanks your advice.
Hope the maintainer will do this minor adjustment.
Thanks,
Li Qiang
> Spotted by ASAN [with] 'make check'.
>
> or
>
> Spotted by ASAN [while running] 'make check'.
>
> Here goes:
>
> "Fixes: 2dbfadf"
>
> > Signed-off-by: Li Qiang <liq3ea@163.com>
> > ---
> > tests/test-bdrv-graph-mod.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> > index 458dfa6661..8bf0fe735d 100644
> > --- a/tests/test-bdrv-graph-mod.c
> > +++ b/tests/test-bdrv-graph-mod.c
> > @@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
> >
> > bdrv_unref(bs);
> > blk_unref(root);
> > + error_free(local_err);
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> > }
> >
> > /*
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak
2019-03-10 11:34 [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak Li Qiang
2019-03-10 14:34 ` Philippe Mathieu-Daudé
@ 2019-03-11 7:55 ` Vladimir Sementsov-Ogievskiy
1 sibling, 0 replies; 4+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-03-11 7:55 UTC (permalink / raw)
To: Li Qiang, kwolf@redhat.com; +Cc: liq3ea@gmail.com, qemu-devel@nongnu.org
10.03.2019 14:34, Li Qiang wrote:
> Fixes: 2dbfadf
> Spotted by ASAN when 'make check'.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
Oops, my fault, thank you for fixing this!
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/test-bdrv-graph-mod.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-bdrv-graph-mod.c b/tests/test-bdrv-graph-mod.c
> index 458dfa6661..8bf0fe735d 100644
> --- a/tests/test-bdrv-graph-mod.c
> +++ b/tests/test-bdrv-graph-mod.c
> @@ -117,6 +117,7 @@ static void test_update_perm_tree(void)
>
> bdrv_unref(bs);
> blk_unref(root);
> + error_free(local_err);
> }
>
> /*
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-12 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-10 11:34 [Qemu-devel] [PATCH] tests: test-bdrv-graph-mod: fix memory leak Li Qiang
2019-03-10 14:34 ` Philippe Mathieu-Daudé
2019-03-12 0:31 ` Li Qiang
2019-03-11 7:55 ` Vladimir Sementsov-Ogievskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).