* [PATCH] vfio/container: Fix vfio_listener_commit()
@ 2025-06-09 11:54 Zhenzhong Duan
2025-06-09 12:01 ` John Levon
2025-06-09 16:33 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: Zhenzhong Duan @ 2025-06-09 11:54 UTC (permalink / raw)
To: qemu-devel
Cc: john.levon, chao.p.peng, Zhenzhong Duan, Alex Williamson,
Cédric Le Goater
It's wrong to call into listener_begin callback in vfio_listener_commit().
Currently this impacts vfio-user.
Fixes: d9b7d8b6993b ("vfio/container: pass listener_begin/commit callbacks")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/vfio/listener.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
index 203ed0314e..735b5f21b7 100644
--- a/hw/vfio/listener.c
+++ b/hw/vfio/listener.c
@@ -437,7 +437,7 @@ static void vfio_listener_commit(MemoryListener *listener)
listener);
void (*listener_commit)(VFIOContainerBase *bcontainer);
- listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_begin;
+ listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_commit;
if (listener_commit) {
listener_commit(bcontainer);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/container: Fix vfio_listener_commit()
2025-06-09 11:54 [PATCH] vfio/container: Fix vfio_listener_commit() Zhenzhong Duan
@ 2025-06-09 12:01 ` John Levon
2025-06-09 16:33 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: John Levon @ 2025-06-09 12:01 UTC (permalink / raw)
To: Zhenzhong Duan
Cc: qemu-devel, chao.p.peng, Alex Williamson, Cédric Le Goater
On Mon, Jun 09, 2025 at 07:54:33PM +0800, Zhenzhong Duan wrote:
> It's wrong to call into listener_begin callback in vfio_listener_commit().
> Currently this impacts vfio-user.
>
> Fixes: d9b7d8b6993b ("vfio/container: pass listener_begin/commit callbacks")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
D'oh, copy-and-paste error, thanks. Somewhat impressive this didn't show up as
any failure in my testing.
Reviewed-by: John Levon <john.levon@nutanix.com>
regards
john
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/container: Fix vfio_listener_commit()
2025-06-09 11:54 [PATCH] vfio/container: Fix vfio_listener_commit() Zhenzhong Duan
2025-06-09 12:01 ` John Levon
@ 2025-06-09 16:33 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2025-06-09 16:33 UTC (permalink / raw)
To: Zhenzhong Duan, qemu-devel; +Cc: john.levon, chao.p.peng, Alex Williamson
On 6/9/25 13:54, Zhenzhong Duan wrote:
> It's wrong to call into listener_begin callback in vfio_listener_commit().
> Currently this impacts vfio-user.
>
> Fixes: d9b7d8b6993b ("vfio/container: pass listener_begin/commit callbacks")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
> hw/vfio/listener.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
> index 203ed0314e..735b5f21b7 100644
> --- a/hw/vfio/listener.c
> +++ b/hw/vfio/listener.c
> @@ -437,7 +437,7 @@ static void vfio_listener_commit(MemoryListener *listener)
> listener);
> void (*listener_commit)(VFIOContainerBase *bcontainer);
>
> - listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_begin;
> + listener_commit = VFIO_IOMMU_GET_CLASS(bcontainer)->listener_commit;
>
> if (listener_commit) {
> listener_commit(bcontainer);
Applied to vfio-next.
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-09 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-09 11:54 [PATCH] vfio/container: Fix vfio_listener_commit() Zhenzhong Duan
2025-06-09 12:01 ` John Levon
2025-06-09 16:33 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).