From: Farhan Ali <alifm@linux.ibm.com>
To: Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kwolf@redhat.com
Subject: Re: [Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the test when user is root
Date: Fri, 30 Nov 2018 16:51:04 -0500 [thread overview]
Message-ID: <4337f943-4a18-87f2-b67a-880db4e2e564@linux.ibm.com> (raw)
In-Reply-To: <cbd1ca87-b547-5649-7449-2f4de203dfd9@redhat.com>
On 11/30/2018 03:52 PM, Eric Blake wrote:
> On 11/30/18 2:37 PM, Farhan Ali wrote:
>> Test 232 creates image files with read-only permission and
>> expects an error message when trying to access the image
>> files with read-only and auto-read-only turned off.
>>
>> Don't run as root user, since root can open files with read/write
>> access for read-only files.
>>
>> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
>> ---
>> tests/qemu-iotests/232 | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> Did you mean to keep RFC in the subject line? Will patchew even spot it
> without PATCH in the subject line?
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Thanks for reviewing the patch. I am not sure if patchew will pick it
up; I have no problem in spinning another patch but I will wait till
Monday to see if anyone else has any feedback.
Thanks
Farhan
prev parent reply other threads:[~2018-11-30 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1543610035.git.alifm@linux.ibm.com>
2018-11-30 20:37 ` [Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the test when user is root Farhan Ali
2018-11-30 20:52 ` Eric Blake
2018-11-30 21:51 ` Farhan Ali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4337f943-4a18-87f2-b67a-880db4e2e564@linux.ibm.com \
--to=alifm@linux.ibm.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).