From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXARJ-0007Xa-Cu for qemu-devel@nongnu.org; Mon, 17 Jul 2017 14:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXARI-0000ab-Hv for qemu-devel@nongnu.org; Mon, 17 Jul 2017 14:08:13 -0400 References: <20170717142620.6970-1-eblake@redhat.com> From: John Snow Message-ID: <433f7790-bfbf-d0a1-a117-b57fb078b70e@redhat.com> Date: Mon, 17 Jul 2017 14:07:58 -0400 MIME-Version: 1.0 In-Reply-To: <20170717142620.6970-1-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , berrange@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com On 07/17/2017 10:26 AM, Eric Blake wrote: > A run of './check -qcow2 -g quick' on my machine produced only > two tests that took longer than 5 seconds; 178 took 18, and > 189 took 7. Remove them from the quick group. > > Signed-off-by: Eric Blake > --- > tests/qemu-iotests/group | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 2aba585287..01f12d6781 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -175,11 +175,11 @@ > 175 auto quick > 176 rw auto backing > 177 rw auto quick > -178 auto quick > +178 auto > 179 rw auto quick > 181 rw auto migration > 182 rw auto quick > 183 rw auto migration > 185 rw auto > 188 rw auto quick > -189 rw auto quick > +189 rw auto > Seems about as scientific as the existing methods used to define the quick group, so why not? Reviewed-by: John Snow