From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: cminyard@mvista.com, Patrick Venture <venture@google.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
Hao Wu <wuhaotsh@google.com>
Subject: Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices
Date: Wed, 22 Mar 2023 22:40:34 +0100 [thread overview]
Message-ID: <434091cb-08d7-15f5-e4ff-5fa867abd3e8@linaro.org> (raw)
In-Reply-To: <ZBtwxzc7xpazByqK@minyard.net>
On 22/3/23 22:19, Corey Minyard wrote:
> On Wed, Mar 22, 2023 at 10:21:36AM -0700, Patrick Venture wrote:
>> This allows the devices to be more readily found and specified.
>> Without setting the name field, they can only be found by device type
>> name, which doesn't let you specify the second of the same device type
>> behind a bus.
>>
>> Tested: Verified that by default the device was findable with the name
>> 'pca954x[77]', for an instance attached at that address.
>
> This looks good to me.
>
> Acked-by: Corey Minyard <cminyard@mvista.com>
>
> if you are taking this in through another tree. Or do you want me to
> take this?
Since I have to send a MIPS PR, I'll take this one;
to alleviate you and the CI minutes.
next prev parent reply other threads:[~2023-03-22 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 17:21 [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices Patrick Venture
2023-03-22 21:19 ` Corey Minyard
2023-03-22 21:40 ` Philippe Mathieu-Daudé [this message]
2023-05-31 16:34 ` Patrick Venture
2023-06-05 20:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434091cb-08d7-15f5-e4ff-5fa867abd3e8@linaro.org \
--to=philmd@linaro.org \
--cc=cminyard@mvista.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).