From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>, qemu-devel@nongnu.org
Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com,
bin.meng@windriver.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, qemu-riscv@nongnu.org,
christoph.muellner@vrull.eu, bjorn@kernel.org
Subject: Re: [PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906
Date: Wed, 31 Jan 2024 15:07:42 +1000 [thread overview]
Message-ID: <4345f1e4-6588-4f17-975d-b9349b07421c@linaro.org> (raw)
In-Reply-To: <20240130111159.532-3-zhiwei_liu@linux.alibaba.com>
On 1/30/24 21:11, LIU Zhiwei wrote:
> +riscv_csr_operations th_csr_ops[CSR_TABLE_SIZE] = {
> +#if !defined(CONFIG_USER_ONLY)
> + [CSR_TH_MXSTATUS] = { "th_mxstatus", th_maee_check, read_th_mxstatus,
> + write_th_mxstatus},
> +#endif /* !CONFIG_USER_ONLY */
> +};
This is clearly the wrong data structure for a single entry in the array.
r~
next prev parent reply other threads:[~2024-01-31 5:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 11:11 [PATCH 0/2] target/riscv: Support mxstatus CSR for thead-c906 LIU Zhiwei
2024-01-30 11:11 ` [PATCH 1/2] target/riscv: Register vendors CSR LIU Zhiwei
2024-01-31 5:06 ` Richard Henderson
2024-01-31 6:14 ` LIU Zhiwei
2024-01-30 11:11 ` [PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906 LIU Zhiwei
2024-01-30 11:43 ` Christoph Müllner
2024-01-31 18:52 ` Conor Dooley
2024-02-04 5:47 ` LIU Zhiwei
2024-01-31 5:07 ` Richard Henderson [this message]
2024-01-31 6:21 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4345f1e4-6588-4f17-975d-b9349b07421c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bjorn@kernel.org \
--cc=christoph.muellner@vrull.eu \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).