From: Paul Durrant <xadimgnik@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
xen-devel@lists.xenproject.org,
"Anthony PERARD" <anthony@xenproject.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()
Date: Thu, 6 Jun 2024 09:36:50 +0100 [thread overview]
Message-ID: <434fea2b-c7e9-42b3-bc1c-27ef811d0027@xen.org> (raw)
In-Reply-To: <20240605131444.797896-4-kraxel@redhat.com>
On 05/06/2024 14:14, Gerd Hoffmann wrote:
> Boolean return value is reversed, to align with QEMU_ALLOCATED_FLAG, so
> all callers must be adapted. Also rename share_surface variable in
> vga_draw_graphic() to reduce confusion.
>
> No functional change.
>
> Suggested-by: Marc-André Lureau <marcandre.lureau@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/ui/surface.h | 4 ++--
> hw/display/qxl-render.c | 2 +-
> hw/display/vga.c | 20 ++++++++++----------
> hw/display/xenfb.c | 5 +++--
> ui/console.c | 3 ++-
> 5 files changed, 18 insertions(+), 16 deletions(-)
>
Reviewed-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2024-06-06 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:14 [PATCH v3 0/3] stdvga: fix screen blanking Gerd Hoffmann
2024-06-05 13:14 ` [PATCH v3 1/3] " Gerd Hoffmann
2024-06-05 13:14 ` [PATCH v3 2/3] ui+display: rename is_placeholder() -> surface_is_placeholder() Gerd Hoffmann
2024-06-18 11:02 ` Philippe Mathieu-Daudé
2024-06-05 13:14 ` [PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated() Gerd Hoffmann
2024-06-06 8:36 ` Paul Durrant [this message]
2024-06-05 13:26 ` [PATCH v3 0/3] stdvga: fix screen blanking Marc-André Lureau
2024-06-18 11:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434fea2b-c7e9-42b3-bc1c-27ef811d0027@xen.org \
--to=xadimgnik@gmail.com \
--cc=anthony@xenproject.org \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).