Re: [PATCH v5] tests: qtest: Add virtio-iommu test

[Eric Auger <eric.auger@redhat.com>]

Hi Thomas,
On 11/2/21 1:58 PM, Thomas Huth wrote:
> On 01/11/2021 19.48, Eric Auger wrote:
>> Add the framework to test the virtio-iommu-pci device
>> and tests exercising the attach/detach, map/unmap API.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Tested-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>>
>> ---
>>
>> v4 -> v5:
>> - remove printf and move a comment
>> - Added Jean-Philippe's T-b and R-b
>
>  Hi Eric,
>
> I tried to add this patch to my queue, but unfortunately, it fails
> some of the gitlab CI pipelines, e.g.:
>
>  https://gitlab.com/thuth/qemu/-/jobs/1739091817#L311
>
>  ...
>  Running test qtest-x86_64/qos-test
>  qemu-system-x86_64: -device virtio-iommu-pci,addr=04.0:
>  pc-i440fx-6.2 machine fails to create iommu-map device tree
>  bindings
>  Check your machine implements a hotplug handler for the
>  virtio-iommu-pci device
>  Check the guest is booted without FW or with -no-acpi
>  Broken pipe
>  ...
>
> Could you please have a look?
The test requires to be applied on top of Jean-Philippe's series
[PATCH v6 0/7] virtio-iommu: Add ACPI support (x86 part) and especially
36efa250a4  hw/i386/pc: Allow instantiating a virtio-iommu device
which allows the instantiation of the virtio-iommu on q35. The series
was merged so the problem should be resolved now.

Thanks

Eric


>
>  Thanks,
>   Thomas
>