From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385CCC433E0 for ; Mon, 8 Feb 2021 14:31:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 106B064E5A for ; Mon, 8 Feb 2021 14:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 106B064E5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l97ZT-0001I4-7L for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 09:31:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l92Se-0005Tq-DX for qemu-devel@nongnu.org; Mon, 08 Feb 2021 04:04:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57577) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l92SE-0001iR-M6 for qemu-devel@nongnu.org; Mon, 08 Feb 2021 04:03:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612775000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEpAGaAlWpUPsiGWyHmZvyW881ytgzfA+TjPnCI2T8A=; b=AFwMA3Tr/+wCrTH9atgAZf7AKX2gg+beh6zJlJ4qV1i2Ho8Nzx3+UY5Rtqy/AQMUSa3HFo BjzWbq3S9hsDDXzkfJZtcG0UsPFtL+Nfxk/eJ+lE/fuVncfgid8PkJPWo/XW6sMg64O46L Q3MVC0ary+t9D/dwUoOgQ4sCkD6GOho= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-d3oCLRFHPPmH8K9WM9aEEw-1; Mon, 08 Feb 2021 04:03:18 -0500 X-MC-Unique: d3oCLRFHPPmH8K9WM9aEEw-1 Received: by mail-wr1-f70.google.com with SMTP id j8so12472984wrx.17 for ; Mon, 08 Feb 2021 01:03:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oEpAGaAlWpUPsiGWyHmZvyW881ytgzfA+TjPnCI2T8A=; b=lu+JilgGmJOnorR9qwH7YUP8ZQZHycf9cjg80X1+0XVJ23t9ZxarbW4o4gIHzBoVbI zEFqMyss3lS2t7ImTXJP9U0zKCxxFK8IRCh5ddnPOJCUZDoKxxDOFjtmr5h6KfkHF8Wz moaTOntlOa/IjIfchiG5Cb+gVvXvQHkRfZgzU/KfHC6lgoyxz41gOUK7r7W4x4i4EiqV F+KVaSp7LSKKz/dWqlMwFKefCqfPJLy4fbCpi5juo3Aoeg0wCMmqXDlM2hLhUfmpLZ6Q wbXp/Sgg9BMxP0GNDZiNTTU/Da6XL8xBbkMx2uNosLjxeQSYayQLuz8/HthaB0b7BOCh psDw== X-Gm-Message-State: AOAM530/r0DWobnYcZD58Y/jUIHxC5ZbQLwc8BjovlXeBxN+TRM1qVdN 4dKKtZmCtCowwgJjp8qZc+IO3TyB2URQL8tCQmW6wVi4iBbvBZQG9N9WMITtbhKOyPV6VaAvUrH CiJFYWrmm16LpPJ8= X-Received: by 2002:a1c:2e83:: with SMTP id u125mr13119891wmu.13.1612774997604; Mon, 08 Feb 2021 01:03:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHTJKo2OUTWTl1QmZGdH7B8o/sMSpVhM5d0HKbDexFSiB4tOpVU4PewNUVlITk2Jk8ZWX5DA== X-Received: by 2002:a1c:2e83:: with SMTP id u125mr13119874wmu.13.1612774997388; Mon, 08 Feb 2021 01:03:17 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id w15sm26630365wrp.15.2021.02.08.01.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 01:03:16 -0800 (PST) Subject: Re: [PATCH] hw/block/nvme: fix Close Zone To: Dmitry Fomichev , Klaus Jensen , Keith Busch , Kevin Wolf , Max Reitz , qemu-devel@nongnu.org References: <20210208003256.9280-1-dmitry.fomichev@wdc.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <435eb631-e53d-a47a-6c27-68d12496fe00@redhat.com> Date: Mon, 8 Feb 2021 10:03:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210208003256.9280-1-dmitry.fomichev@wdc.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niklas Cassel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Dmitry, Klaus. On 2/8/21 1:32 AM, Dmitry Fomichev wrote: > Implicitly and Explicitly Open zones can be closed by Close Zone > management function. This got broken by a recent commit and now such > commands fail with Invalid Zone State Transition status. > > Modify nvm_zrm_close() function to make Close Zone work correctly. > > Signed-off-by: Dmitry Fomichev > Fixes: 053b5a302c3("hw/block/nvme: refactor zone resource management") '053b5a302c3': unknown revision or path not in the working tree. If you point at an unmerged commit, why not fix it directly before merging? > --- > hw/block/nvme.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 6b84e34843..c2f0c88fbf 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -1308,14 +1308,13 @@ static uint16_t nvme_zrm_finish(NvmeNamespace *ns, NvmeZone *zone) > static uint16_t nvme_zrm_close(NvmeNamespace *ns, NvmeZone *zone) > { > switch (nvme_get_zone_state(zone)) { > - case NVME_ZONE_STATE_CLOSED: > - return NVME_SUCCESS; > - > case NVME_ZONE_STATE_EXPLICITLY_OPEN: > case NVME_ZONE_STATE_IMPLICITLY_OPEN: > nvme_aor_dec_open(ns); > nvme_assign_zone_state(ns, zone, NVME_ZONE_STATE_CLOSED); > /* fall through */ > + case NVME_ZONE_STATE_CLOSED: > + return NVME_SUCCESS; > > default: > return NVME_ZONE_INVAL_TRANSITION; >