From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5084C54FCB for ; Thu, 23 Apr 2020 18:09:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76F8720767 for ; Thu, 23 Apr 2020 18:09:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ANgaKxXa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76F8720767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRgIK-0003J6-Ix for qemu-devel@archiver.kernel.org; Thu, 23 Apr 2020 14:09:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56016) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRgEm-0006Q6-Hm for qemu-devel@nongnu.org; Thu, 23 Apr 2020 14:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRgEl-0004JC-PJ for qemu-devel@nongnu.org; Thu, 23 Apr 2020 14:06:12 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55749 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jRgEl-0004Ej-Bo for qemu-devel@nongnu.org; Thu, 23 Apr 2020 14:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587665169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zUazrkoiJbvngoPwri/a/Mtee9YJHSZCYMzK7Zg7DM=; b=ANgaKxXaFn87ltLCGi5k+OZgmRmnrUnGg0WyZvDCjeNqMR73wKP2zoW1v5U/2ZJDFLvC7h AUQy6Qup43Mxohh5LafNiVivphsL/Ct+qVhC4JKYZ6DHuo7WgBPPyPjdsvIWE868GpSRup D2DVve/0cqAJIYccsI9jEhcJHRFZcuk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-pF37y2QWOtW4MmDW3PyrdQ-1; Thu, 23 Apr 2020 14:06:05 -0400 X-MC-Unique: pF37y2QWOtW4MmDW3PyrdQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC2CC180F105; Thu, 23 Apr 2020 18:06:04 +0000 (UTC) Received: from [10.10.116.80] (ovpn-116-80.rdu2.redhat.com [10.10.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 344AA5D714; Thu, 23 Apr 2020 18:06:03 +0000 (UTC) Subject: Re: [PATCH 10/13] qapi: Clean up visitor's recovery from input with invalid type To: Markus Armbruster , qemu-devel@nongnu.org References: <20200423160036.7048-1-armbru@redhat.com> <20200423160036.7048-11-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <435f2d5d-e732-a236-bf13-991d5c3510e6@redhat.com> Date: Thu, 23 Apr 2020 13:06:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200423160036.7048-11-armbru@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/23 02:14:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/23/20 11:00 AM, Markus Armbruster wrote: > An alternate type's visit_type_FOO() fails when it runs into an > invalid ->type. If it's an input visit, we then need to free the the > object we got from visit_start_alternate(). We do that with > qapi_free_FOO(), which uses the dealloc visitor. > > Trouble is that object is in a bad state: its ->type is invalid. So > the dealloc visitor will run into the same error again, and the error > recovery skips deallocating the alternate's (invalid) alternative. > This is a roundabout way to g_free() the alternate. > > Simplify: replace the qapi_free_FOO() by g_free(). > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/visit.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Required looking at what gets generated into qapi_free_FOO() as well as when visit_start_alternate() can fail, but makes sense. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org