Re: [Qemu-devel] [patch] USB support

[Oliver Gerlich <olig9@gmx.de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Fabrice Bellard schrieb:
> Lonnie Mendez wrote:
> 
>> On Saturday 05 November 2005 11:10 am, Fabrice Bellard wrote:
>>
>>> 1) The host OS must not use the USB device. It means in particular
>>> that no host OS driver must be present for that device. The solution
>>> I am using is to rename the host kernel module "usb-storage.o" to
>>> "usb-storage.o.disabled" so that it is not loaded by Linux. Then QEMU
>>> can exclusively access to the corresponding host storage USB device.
>>> The same apply to every other type of USB devices.
>>
>>
>>
>>    usb devfs has a disconnect ioctl (USBDEVFS_DISCONNECT) which
>> allows you to disconnect a single device from a driver.
>>
>>    A suggestion is to hook the interface up to qemu monitor.  Then you
>> would be able to list usb devices and then claim only the ones you
>> want to use.
> 
> 
> Good idea. I am adding something like that:
> 
> In the monitor:
> 
> 'info usbhost' lists the available host USB devices
> 
> 'usbhost_add 3.4' or 'usbhost_add 1234:5678' adds the USB host device on
> bus 3 at address 4 or the first one matching the vendor ID 0x1234 and
> product ID 0x5678.
> 
> The QEMU option '-usbhost x' can be used to do the same as usbhost_add.
> 
> Fabrice.
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 

When I use usb_add, I get:
USBDEVFS_DISCONNECT: Inappropriate ioctl for device

This is with snapshot from 2005-11-11, on Debian testing, kernel 2.6.13
(with 1000Hz timer).
The patch below fixes this (plainly taken from
http://www.mail-archive.com/linux-usb-devel@lists.sourceforge.net/msg35550.html
; is ifno = 0 correct?)


diff -Naur qemu-snapshot-2005-11-11_23/usb-linux.c
qemu-snapshot-2005-11-11_23-usb/usb-linux.c
- --- qemu-snapshot-2005-11-11_23/usb-linux.c     2005-11-06
17:13:29.000000000 +0
100
+++ qemu-snapshot-2005-11-11_23-usb/usb-linux.c 2005-11-13
01:10:19.000000000 +0
100
@@ -181,7 +181,10 @@

 #ifdef USBDEVFS_DISCONNECT
     /* earlier Linux 2.4 do not support that */
- -    ret = ioctl(fd, USBDEVFS_DISCONNECT);
+    struct usbdevfs_ioctl ctrl;
+    ctrl.ioctl_code = USBDEVFS_DISCONNECT;
+    ctrl.ifno = 0;
+    ret = ioctl(fd, USBDEVFS_IOCTL, &ctrl);
     if (ret < 0 && errno != ENODATA) {
         perror("USBDEVFS_DISCONNECT");
         goto fail;


With this patch, qemu recognized all USB devices I had available - which
is actually only one device, a joystick :)
Win2k showed it in the control panel with all available buttons and axes
and reacted to events correctly.

Though, a strange thing is that as long as the device is attached to the
guest, Windows gets very slow. The Windows task manager shows that the
guest CPU load is at 100%; but "top" on the guest shows that qemu uses
only 20% host CPU. This starts as soon as usb_add is executed, and stops
as soon as usb_del is executed.
Does qemu use sleep in the usb code, or does maybe Windows sent the CPU
a HLT ? I don't really understand that behaviour :)


Regards,
Oliver
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDdpAWTFOM6DcNJ6cRAjzgAJ4rJlhVBe8thmg3VCBRRs+iw7dCsgCeI8s/
vDSywn5WpfH4vkCNSfEpDvI=
=Djpx
-----END PGP SIGNATURE-----