From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] virtiofsd: Fix the help message of posix lock
Date: Tue, 27 Oct 2020 09:42:50 +0100 [thread overview]
Message-ID: <437ac64b-fca8-2092-2bdc-8c3fbdea5161@redhat.com> (raw)
In-Reply-To: <20201027081558.29904-1-zhangjiachen.jaycee@bytedance.com>
On 10/27/20 9:15 AM, Jiachen Zhang wrote:
> The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
> posix locks by default. But the --help message still says it is enabled
> by default. So fix it to output no_posix_lock.
>
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tools/virtiofsd/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 85770d63f1..574dd09e91 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
> " allowed (default: 10)\n"
> " -o posix_lock|no_posix_lock\n"
> " enable/disable remote posix lock\n"
> - " default: posix_lock\n"
> + " default: no_posix_lock\n"
> " -o readdirplus|no_readdirplus\n"
> " enable/disable readirplus\n"
> " default: readdirplus except with "
>
next prev parent reply other threads:[~2020-10-27 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé [this message]
2020-10-27 18:33 ` Dr. David Alan Gilbert
2020-11-02 18:43 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437ac64b-fca8-2092-2bdc-8c3fbdea5161@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhangjiachen.jaycee@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).