From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning
Date: Wed, 21 Dec 2022 08:16:14 +0100 [thread overview]
Message-ID: <4398ae9e-c29a-503f-0738-4a4a161eb714@linaro.org> (raw)
In-Reply-To: <eac96f81-8cd5-5951-6b0f-69da5985d47c@linaro.org>
On 21/12/22 02:01, Richard Henderson wrote:
> On 12/20/22 06:25, Philippe Mathieu-Daudé wrote:
>> Silent when compiling with -Wextra:
>>
>> ../hw/arm/nseries.c:1081:12: warning: missing field 'line'
>> initializer [-Wmissing-field-initializers]
>> { NULL }
>> ^
>>
>> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
>> ---
>> hw/arm/nseries.c | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Not a fan of this specific warning.
Me neither, and I don't think we can enforce it on QEMU codebase.
However I find '{ /* end of list */ }' cleaner/clearer than assigning
the first field.
next prev parent reply other threads:[~2022-12-21 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 14:25 [PATCH 0/3] hw/arm/nseries: Minor housekeeping Philippe Mathieu-Daudé
2022-12-20 14:25 ` [PATCH 1/3] hw/input/tsc2xxx: Constify set_transform()'s MouseTransformInfo arg Philippe Mathieu-Daudé
2022-12-21 1:00 ` Richard Henderson
2022-12-20 14:25 ` [PATCH 2/3] hw/arm/nseries: Constify various read-only arrays Philippe Mathieu-Daudé
2022-12-21 1:01 ` Richard Henderson
2022-12-20 14:25 ` [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning Philippe Mathieu-Daudé
2022-12-21 1:01 ` Richard Henderson
2022-12-21 7:16 ` Philippe Mathieu-Daudé [this message]
2022-12-21 17:12 ` Richard Henderson
2023-01-05 14:11 ` [PATCH 0/3] hw/arm/nseries: Minor housekeeping Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4398ae9e-c29a-503f-0738-4a4a161eb714@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).