From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: various iotests failures apparently due to overly optimistic timeout settings
Date: Mon, 20 Jul 2020 10:18:09 -0400 [thread overview]
Message-ID: <439a5b00-997d-dbd2-f8d9-55d440ebd567@redhat.com> (raw)
In-Reply-To: <CAFEAcA_SWO7fwR6nDAn9=HoYOVEf=L6AomjsonjbscPvTejQQA@mail.gmail.com>
On 7/20/20 10:15 AM, Peter Maydell wrote:
> On Mon, 20 Jul 2020 at 15:12, John Snow <jsnow@redhat.com> wrote:
>>
>> On 7/20/20 6:46 AM, Kevin Wolf wrote:
>>> John, I think this is a result of your recent python/qemu/ changes that
>>> make failure of graceful shutdown an error rather than just silently
>>> falling back to SIGKILL.
>>>
>>> Should the default timeout be longer, should iotests override the
>>> default, or should iotests just always kill their VM instead of trying
>>> to shut it down gracefully?
>
>> Let's make it longer. Since you are seeing the failures, can you edit
>> python/qemu/machine.py and find the default timeout of 3 seconds for
>> shutdown() and change it to 10? 30? 60?
>
> Not conveniently, because this is for merge pull requests, and
> all the iotests failures are nested inside the tests/vm BSD VM
> setup.
I meant permanently, for everything -- not as a one-off for just this case.
--js
next prev parent reply other threads:[~2020-07-20 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 12:07 various iotests failures apparently due to overly optimistic timeout settings Peter Maydell
2020-07-20 10:46 ` Kevin Wolf
2020-07-20 14:12 ` John Snow
2020-07-20 14:15 ` Peter Maydell
2020-07-20 14:18 ` John Snow [this message]
2020-07-20 14:21 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439a5b00-997d-dbd2-f8d9-55d440ebd567@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).