qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel][PATCH] Tap and VLAN socket support for win32
Date: Sat, 04 Feb 2006 19:28:31 +0100	[thread overview]
Message-ID: <43E4F24F.6040908@bellard.org> (raw)
In-Reply-To: <000a01c627df$fc48d660$0464a8c0@athlon>

Kazu wrote:
> Thursday, February 02, 2006 8:10 AM Fabrice Bellard wrote:
> 
>> Hi,
>>
>> I merged your patches and I made important changes to simplify them. I
>> did not do any tests so tell me if you see problems.
>>
> 
> -net socket,connect doesn't work. On Windows host, connect returns with err
> = WSAEWOULDBLOCK and second time err = WSAEINVAL. I think changing the 
> place
> of EWOULDBLOCK would be good. On Linux host, EWOULDBLOCK is the same as
> EAGAIN but a patch works on both Linux and Windows.

Unfortunately on Linux the correct return value we are expecting is 
EINPROGRESS. EAGAIN means that the 'connect' was not initiated so it is 
necessary to redo it.

> 
> For -net socket,mcast, bind have to be done by sin_addr.s_addr = 
> INADDR_ANY.
> It seems that it works on Linux host.

It works on Linux but it is not correct because it prevents from 
listening to several multicast addresses at the same time. If doing the 
same on Windows is not possible I agree to make a special case.

Fabrice.

  reply	other threads:[~2006-02-04 23:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-31  7:34 [Qemu-devel][PATCH] Tap and VLAN socket support for win32 Kazu
2006-01-31 16:00 ` André Braga
2006-02-01 23:10 ` Fabrice Bellard
2006-02-02 10:03   ` Kazu
2006-02-04 18:28     ` Fabrice Bellard [this message]
2006-02-09  2:29       ` Kazu
2006-02-09 14:00       ` Kazu
2006-02-05  4:05   ` Jim C. Brown
2006-02-07 21:18   ` Jim C. Brown
2006-02-07 21:44     ` Fabrice Bellard
2006-02-08  7:23       ` David Fraser
2006-02-08  7:32         ` M. Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E4F24F.6040908@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).