From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1F5WW0-0001al-5h
	for qemu-devel@nongnu.org; Sat, 04 Feb 2006 18:08:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1F5WBU-0004JF-Ki
	for qemu-devel@nongnu.org; Sat, 04 Feb 2006 17:47:14 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1F5UXJ-0004oy-DH
	for qemu-devel@nongnu.org; Sat, 04 Feb 2006 16:01:37 -0500
Received: from [84.96.92.55] (helo=smtP.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1F5S9E-0005w4-OM
	for qemu-devel@nongnu.org; Sat, 04 Feb 2006 13:28:36 -0500
Received: from [84.102.211.219] by sp604004mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005))
	with ESMTP id <0IU600CTODVF7M10@sp604004mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 04 Feb 2006 19:26:03 +0100 (CET)
Date: Sat, 04 Feb 2006 19:28:31 +0100
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel][PATCH] Tap and VLAN socket support for win32
In-reply-to: <000a01c627df$fc48d660$0464a8c0@athlon>
Message-id: <43E4F24F.6040908@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <000c01c62638$d55e7800$0464a8c0@athlon>
	<43E13FEC.7050804@bellard.org> <000a01c627df$fc48d660$0464a8c0@athlon>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Kazu wrote:
> Thursday, February 02, 2006 8:10 AM Fabrice Bellard wrote:
> 
>> Hi,
>>
>> I merged your patches and I made important changes to simplify them. I
>> did not do any tests so tell me if you see problems.
>>
> 
> -net socket,connect doesn't work. On Windows host, connect returns with err
> = WSAEWOULDBLOCK and second time err = WSAEINVAL. I think changing the 
> place
> of EWOULDBLOCK would be good. On Linux host, EWOULDBLOCK is the same as
> EAGAIN but a patch works on both Linux and Windows.

Unfortunately on Linux the correct return value we are expecting is 
EINPROGRESS. EAGAIN means that the 'connect' was not initiated so it is 
necessary to redo it.

> 
> For -net socket,mcast, bind have to be done by sin_addr.s_addr = 
> INADDR_ANY.
> It seems that it works on Linux host.

It works on Linux but it is not correct because it prevents from 
listening to several multicast addresses at the same time. If doing the 
same on Windows is not possible I agree to make a special case.

Fabrice.