From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB19C4338F for ; Tue, 17 Aug 2021 07:27:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7291960C3E for ; Tue, 17 Aug 2021 07:27:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7291960C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFtVu-0006Bc-EV for qemu-devel@archiver.kernel.org; Tue, 17 Aug 2021 03:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFtU3-0003Y1-1R for qemu-devel@nongnu.org; Tue, 17 Aug 2021 03:26:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFtU1-0002zt-Mw for qemu-devel@nongnu.org; Tue, 17 Aug 2021 03:26:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629185160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gh5AGTgqltMsAaXtL1tirg3uBseXDjWOJFl2FFZM1sc=; b=MsgZf6zqnQf2wkXvlYCha8mCHtebeMwTtdBQE6wmrkn1DabatId4p4jWNYFYt1TNvX1Tht eqlJBsllks9OmMpF5NIJNArGvYAPorqn4FPS+O7IGM1WXKGnnGOu63rMY9z3QlqDOdxEsW OfEcF1hQyM+uO01Vg+7XlMRvtN/B8o0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-VKErzJblNlObzdkhO0T45A-1; Tue, 17 Aug 2021 03:25:59 -0400 X-MC-Unique: VKErzJblNlObzdkhO0T45A-1 Received: by mail-wm1-f72.google.com with SMTP id r125-20020a1c2b830000b0290197a4be97b7so580223wmr.9 for ; Tue, 17 Aug 2021 00:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Gh5AGTgqltMsAaXtL1tirg3uBseXDjWOJFl2FFZM1sc=; b=deuEP9amvnCcSQyt138P2QB6JFHMdqazQC80a0WKNVXWPgiwh4nJJ9/EYvXFfBFLVC DKYl/Bg8QjxL/rqz4L9cgwSS7QUvDSFehlDVn7D4fM5IjM6JEba7ucpaXnMjLTpwz8Hs YnYq0QQBRsOSeXK8UDN5lKy9W5VBYP96FYbbdHWzY0BQcnMdyv+QfUWe2NaEvaOfDmB5 1xS4uqdnqUgiKFATX9ZbzJgR4rDYPsWvuAnxyzfVP1yUTonL2M3pPT7jTMH286nTmKIK G3O0zWNhtwg8MY4gN47N1sPZ3yX2cPVIqWWcBR7RKRk+q5ZyDJqvrH2Muj79UdfIPWmy TRNA== X-Gm-Message-State: AOAM533W6KyvXGLT/ekabw+2zvjYLe9hdUOlhETfxN8aqlDj/rnPTbZF A8kT77U91GdNhkKbLvGbHhnjzPtKAHbaohepYBXXJW8KFSY/nf8hqsIE1Ep+nlvKlBX9q7Yfi32 dceta5+k1LOoC4qI= X-Received: by 2002:adf:eb4a:: with SMTP id u10mr2205683wrn.11.1629185157737; Tue, 17 Aug 2021 00:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBI1+fyClY1CLrFaY405OGcbBOD/yF+giOKU1+pXa2TrbGhKA/QC7t9imMTtvBrkUd5F2jtw== X-Received: by 2002:adf:eb4a:: with SMTP id u10mr2205673wrn.11.1629185157602; Tue, 17 Aug 2021 00:25:57 -0700 (PDT) Received: from [192.168.3.132] (p5b0c65c6.dip0.t-ipconnect.de. [91.12.101.198]) by smtp.gmail.com with ESMTPSA id n13sm1186864wmc.18.2021.08.17.00.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 00:25:57 -0700 (PDT) Subject: Re: [PATCH RESEND 2/2] memory: Add tracepoint for dirty sync To: Peter Xu , qemu-devel@nongnu.org References: <20210817013553.30584-1-peterx@redhat.com> <20210817013706.30986-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <43b42f6e-f2a2-6341-0c53-bcf1586fb191@redhat.com> Date: Tue, 17 Aug 2021 09:25:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817013706.30986-1-peterx@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -71 X-Spam_score: -7.2 X-Spam_bar: ------- X-Spam_report: (-7.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.71, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17.08.21 03:37, Peter Xu wrote: > Trace at memory_region_sync_dirty_bitmap() for log_sync() or global_log_sync() > on memory regions. One trace line should suffice when it finishes, so as to > estimate the time used for each log sync process. I wonder if a start/finish would be even nicer. At least it wouldn't really result in significantly more code changes :) -- Thanks, David / dhildenb