qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 11/14] linux-user/elfload.c: Fix incorrect ARM HWCAP bits
Date: Fri,  2 May 2014 22:15:46 +0300	[thread overview]
Message-ID: <43ce393ee5f7b96d2ac22fedc40d6b6fb3f65a3e.1399057853.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1399057853.git.riku.voipio@linaro.org>

From: Peter Maydell <peter.maydell@linaro.org>

The ELF HWCAP bits for ARM features THUMBEE, NEON, VFPv3 and VFPv3D16 are
all off by one compared to the kernel definitions. Fix this discrepancy
and add in the missing CRUNCH bit which was the cause of the off-by-one
error. (We don't emulate any of the CPUs which have that weird hardware,
so it's otherwise uninteresting to us.)

Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/elfload.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index ecf6f35..18ea1b3 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -346,10 +346,11 @@ enum
     ARM_HWCAP_ARM_EDSP      = 1 << 7,
     ARM_HWCAP_ARM_JAVA      = 1 << 8,
     ARM_HWCAP_ARM_IWMMXT    = 1 << 9,
-    ARM_HWCAP_ARM_THUMBEE   = 1 << 10,
-    ARM_HWCAP_ARM_NEON      = 1 << 11,
-    ARM_HWCAP_ARM_VFPv3     = 1 << 12,
-    ARM_HWCAP_ARM_VFPv3D16  = 1 << 13,
+    ARM_HWCAP_ARM_CRUNCH    = 1 << 10,
+    ARM_HWCAP_ARM_THUMBEE   = 1 << 11,
+    ARM_HWCAP_ARM_NEON      = 1 << 12,
+    ARM_HWCAP_ARM_VFPv3     = 1 << 13,
+    ARM_HWCAP_ARM_VFPv3D16  = 1 << 14,
 };
 
 #ifndef TARGET_AARCH64
-- 
2.0.0.rc0

  parent reply	other threads:[~2014-05-02 19:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 19:15 [Qemu-devel] [PULL 00/14] linux-user update riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 01/14] linux-user: Add /proc/self/exe open forwarding riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 02/14] linux-user: Assert stack used for auxvec, envp, argv riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 03/14] linux-user: Move if-elses to a switch statement riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 04/14] linux-user: Add support for SCM_CREDENTIALS riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 05/14] linux-user: Handle arches with llseek instead of _llseek riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 06/14] linux-user: avoid using glibc internals in _syscall5 and in definition of target_sigevent struct riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 07/14] linux-user/signal.c: Set fault address in AArch64 signal info riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 08/14] linux-user: rename cpu-uname -> uname riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 09/14] linux-user: move uname functions to uname.c riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 10/14] linux-user: remove configure option for setting uname release riku.voipio
2014-05-02 19:15 ` riku.voipio [this message]
2014-05-02 19:15 ` [Qemu-devel] [PULL 12/14] linux-user/elfload.c: Update ARM HWCAP bits riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 13/14] linux-user/elfload.c: Fix A64 code which was incorrectly acting like A32 riku.voipio
2014-05-02 19:15 ` [Qemu-devel] [PULL 14/14] linux-user/elfload.c: Support ARM HWCAP2 flags riku.voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ce393ee5f7b96d2ac22fedc40d6b6fb3f65a3e.1399057853.git.riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).